From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sympa.inria.fr (Postfix) with ESMTPS id A72427EF1E for ; Tue, 19 Jul 2016 17:09:18 +0200 (CEST) IronPort-PHdr: 9a23:WbYzCRcQDTak0/UaAHFeo5dnlGMj4u6mDksu8pMizoh2WeGdxc69YR7h7PlgxGXEQZ/co6odzbGH6+a9ACdfsd6oizMrSNR0TRgLiMEbzUQLIfWuLgnFFsPsdDEwB89YVVVorDmROElRH9viNRWJ+iXhpQAbFhi3DwdpPOO9QteU1JXvkb3rsMKDKyxzxxOFKYtoKxu3qQiD/uI3uqBFbpgL9x3Sv3FTcP5Xz247bXianhL7+9vitMU7q3cYk7sb+sVBSaT3ebgjBfwdVWx+cjN92Mq+khLKSA/Hw3IdVmQQnVJsAhPZpEXxV5L19y/7rfZV2S+APMSwQ6piChq46KI+eRj0gSJPHTcj9mbGwphhi75SpRiovRp40qbbZYiUMLx1eaaLLoBSfnZIQssED38JOYi7dYZaSrNZZes= Authentication-Results: mail3-smtp-sop.national.inria.fr; spf=None smtp.pra=yotambarnoy@gmail.com; spf=Pass smtp.mailfrom=yotambarnoy@gmail.com; spf=None smtp.helo=postmaster@mail-yw0-f175.google.com Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of yotambarnoy@gmail.com) identity=pra; client-ip=209.85.161.175; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="yotambarnoy@gmail.com"; x-sender="yotambarnoy@gmail.com"; x-conformance=sidf_compatible Received-SPF: Pass (mail3-smtp-sop.national.inria.fr: domain of yotambarnoy@gmail.com designates 209.85.161.175 as permitted sender) identity=mailfrom; client-ip=209.85.161.175; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="yotambarnoy@gmail.com"; x-sender="yotambarnoy@gmail.com"; x-conformance=sidf_compatible; x-record-type="v=spf1" Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of postmaster@mail-yw0-f175.google.com) identity=helo; client-ip=209.85.161.175; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="yotambarnoy@gmail.com"; x-sender="postmaster@mail-yw0-f175.google.com"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DIAACTQY5Xhq+hVdFchBV8Bq0mizuBeh6HJwc4FAEBAQEBAQEBEQEBAQgLCwkhL4IyBAESAYIrER0BGx4DEhAPAiYCJAERAQUBIhsah3MBAxcOnmiCB4EyPjGLO4FqgloFhEwKGScNUoN1AgEFEHGFKYRNh0GCWgWZJIE1hF6IT483jl8SHoEPHoJBEQuBaCAyiCUBAQE X-IPAS-Result: A0DIAACTQY5Xhq+hVdFchBV8Bq0mizuBeh6HJwc4FAEBAQEBAQEBEQEBAQgLCwkhL4IyBAESAYIrER0BGx4DEhAPAiYCJAERAQUBIhsah3MBAxcOnmiCB4EyPjGLO4FqgloFhEwKGScNUoN1AgEFEHGFKYRNh0GCWgWZJIE1hF6IT483jl8SHoEPHoJBEQuBaCAyiCUBAQE X-IronPort-AV: E=Sophos;i="5.28,390,1464645600"; d="scan'208";a="185243630" Received: from mail-yw0-f175.google.com ([209.85.161.175]) by mail3-smtp-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 19 Jul 2016 17:09:17 +0200 Received: by mail-yw0-f175.google.com with SMTP id j12so11527388ywb.2 for ; Tue, 19 Jul 2016 08:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=7Tk+X6RkARTiB0nbPsWes/HpGc5Wrg9KPNy/aGLD+80=; b=wLy831ffM5ZB/3ZMWJRE4nmR1fCuy+7HjGV/cRieAvsFVsWBHai+2jQ7aViWK5vdwK /5af1Uqti7Em5pPIUBAr2ApHz96Ml7zcWs3j+mszUd2PPicOPv/zGLCxbaaxTtC7R7o9 Zghuvcba7fTig+z9MlWqangnIVWQwdSSstoPNhMCMMljXzQN409bXRIrckAP8W66yov5 T4TQran8raZ9zsrTqnLVJlR5mfK+g2yyzYSP+vFALX0ZrZtoE+TabT+R2NXeGI7X+Egk iwkPeMigHZ8PMTeEeF1QH22n5t4krsXV/QTkiXYPwxD5kfUWZIrLHI9nN2yOr3LVdwML Yz5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=7Tk+X6RkARTiB0nbPsWes/HpGc5Wrg9KPNy/aGLD+80=; b=X4NC3SOkvAfx7CPDUfUs30U9lrC+C311/bhMhOGJZXf4asGyBzzluKlx4w8AIIZ5v/ XrlgwcucCpGB3TtWxuY4NN9nMNDgEF/9uYdFwECTkyp1phGw9/yo9FMrWR2OIF1LKxQg Fbu4C6RKDsguadW7wi7WUi/xSaGI7VC+cqKJxbwCB/5GipgCGqZcAXGDqRlZmq3MEWaO 5j7EUi+BJNn+v+JPVAOgwh7OjM57Fz7GMohqJ0AN+/ZNHtd3PJKKKpOcGpPg8t1Uldmh qPTKfNNCQ3lhXnMtapwiDRxy6yyjAmkH2S7KCdR6um+JgZBJsr5w9bjppsFfulYuuscR MEdw== X-Gm-Message-State: ALyK8tIIx9iuxrjr0TlBKDALHaBQOuA+L+ZbuscF2y+S7MlJzw2ktGo9URGfGMxji7parW3tVQjPCxNMYMd74w== X-Received: by 10.13.192.131 with SMTP id b125mr5820632ywd.161.1468940956173; Tue, 19 Jul 2016 08:09:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.214.204 with HTTP; Tue, 19 Jul 2016 08:08:56 -0700 (PDT) From: Yotam Barnoy Date: Tue, 19 Jul 2016 11:08:56 -0400 Message-ID: To: Ocaml Mailing List Content-Type: text/plain; charset=UTF-8 Subject: [Caml-list] Recent hooks design and general github PR issues I would like to alert the list to a potential problem with github PRs, and a recent example of such a problem. I've noticed that recently, there has been an insertion of a particular feature into the compiler. This feature involves potentially long-term commitment in terms of maintenance, and yet I have not seen it or its costs vs benefits being discussed fully in any particular place. I'm specifically talking about PRs https://github.com/ocaml/ocaml/pull/648, https://github.com/ocaml/ocaml/pull/668 and https://github.com/ocaml/ocaml/pull/647. The problem with github PRs is that they allow you to insert features piecemeal. This splits up the discussion across multiple PRs, making it very difficult to have a discussion about the feature as a whole, and making it seem like there is consensus when there might not be. As a rule, I recommend that any such large feature spanning multiple PRs first require discussion either on the list or on mantis, to concentrate discussion in one place. It may also be worthwhile to say that except for rare exceptions (mostly bug fixes), PRs should not be merged by the same person who authored them, as this makes the process seem biased and questionable. I don't know if this feature in itself is problematic, but I've seen several core members trying to voice concerns about the feature in one PR, while other member PRs were simply merged into the tree. In my opinion, questions on sub-PRs of a feature should inhibit merging any parts of said feature. This may be a false alert, but I think it is worth clarifying if it is indeed one, and at the very least, the protocol should be set for the future. -Yotam