From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sympa.inria.fr (Postfix) with ESMTPS id 3FCEB7F89E for ; Sat, 22 Mar 2014 09:29:11 +0100 (CET) Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of gabriel.scherer@gmail.com) identity=pra; client-ip=209.85.220.173; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="gabriel.scherer@gmail.com"; x-sender="gabriel.scherer@gmail.com"; x-conformance=sidf_compatible Received-SPF: Pass (mail3-smtp-sop.national.inria.fr: domain of gabriel.scherer@gmail.com designates 209.85.220.173 as permitted sender) identity=mailfrom; client-ip=209.85.220.173; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="gabriel.scherer@gmail.com"; x-sender="gabriel.scherer@gmail.com"; x-conformance=sidf_compatible; x-record-type="v=spf1" Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of postmaster@mail-vc0-f173.google.com) identity=helo; client-ip=209.85.220.173; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="gabriel.scherer@gmail.com"; x-sender="postmaster@mail-vc0-f173.google.com"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhkCAFdJLVPRVdytlGdsb2JhbAA/GoNBV6wCjy+HOoENCBYOAQEBAQcLCwkSKoIlAQEBBAEBAT0BGxILAQMMBgULDQ0JAQEWIgEEAQwBBQEKEgYTEodSAQMRDTafK4xfgw6WfQoZJwMKZIYoEQEFDIxvgXQHEgEFhCAElXOCV4EyjxAYKYRcPIEuBxc X-IPAS-Result: AhkCAFdJLVPRVdytlGdsb2JhbAA/GoNBV6wCjy+HOoENCBYOAQEBAQcLCwkSKoIlAQEBBAEBAT0BGxILAQMMBgULDQ0JAQEWIgEEAQwBBQEKEgYTEodSAQMRDTafK4xfgw6WfQoZJwMKZIYoEQEFDIxvgXQHEgEFhCAElXOCV4EyjxAYKYRcPIEuBxc X-IronPort-AV: E=Sophos;i="4.97,708,1389740400"; d="scan'208";a="53660962" Received: from mail-vc0-f173.google.com ([209.85.220.173]) by mail3-smtp-sop.national.inria.fr with ESMTP/TLS/RC4-SHA; 22 Mar 2014 09:29:10 +0100 Received: by mail-vc0-f173.google.com with SMTP id il7so3720663vcb.32 for ; Sat, 22 Mar 2014 01:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=rXNKySYfSgjYLR29JIGbbD9oxxCZeCt+uJjrXtWYlRg=; b=BV9p5XNVcAiGirer2rZgR6UlgmlwQ1GejyfrFkx0vbfQ/W8pTT4vxaxIXdQnaBvHQa ERE3MkyuhxBnubU5F9ZkIjjILHmNdUS2si0KoASFbSgUTfskn2YUwQntxqgfKTQkmtDe 68+60yFXl7D0pyQJ6OfvGjtVDii25+95ugpl3o+JJCHCcTy1hBscaZYkkEBf5TA97x6s n41xf2VmqWfRJ9rXx+J9+hznx7StQR7dK1GexJY2sbXsMBMnVlKFScyHx6C5EVFaoNpP ceMRIND3y8iqJHK5b+2vi2LS/CQss+tZR3Z5+RuTxk3kmBmAeClnrPiB7wpP7LzL43zg OZAg== X-Received: by 10.58.57.67 with SMTP id g3mr40645495veq.3.1395476949169; Sat, 22 Mar 2014 01:29:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.96.5 with HTTP; Sat, 22 Mar 2014 01:28:29 -0700 (PDT) In-Reply-To: <20140322071508.GB10374@annexia.org> References: <20140321222842.GA10374@annexia.org> <4C341FFE-FDF2-4EA3-B056-D4F658641E4C@math.nagoya-u.ac.jp> <20140322071508.GB10374@annexia.org> From: Gabriel Scherer Date: Sat, 22 Mar 2014 09:28:29 +0100 Message-ID: To: "Richard W.M. Jones" Cc: Jacques Garrigue , OCaML List Mailing Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Caml-list] Trivial compiler patches I just created a Mantis issue for the patch: http://caml.inria.fr/mantis/view.php?id=6351 The workflow is the following: - login; your password should be (random-generated and) recorded in your browser, two clicks - click "report issue", fill relevant info, upload patch, send It's about two minutes. Alternatively you could have sent a pull-request against github/ocaml/ocaml (as part of the ongoing "patch review experiment" http://alan.petitepomme.net/cwn/2014.02.04.html#2 ), but I think the workflow is not much quicker (though there are command-line tools to make it faster). I looked at the code and indeed the fix itself is trivial, but it was still useful to make a review: the corresponding arm/emit.mlp change had additional primitive-registering stuff, and I wondered whether that also needed to be done in arm64/emit.mlp (answer: no, that is the only necessary change). On Sat, Mar 22, 2014 at 8:15 AM, Richard W.M. Jones wrote: > On Sat, Mar 22, 2014 at 09:46:53AM +0900, Jacques Garrigue wrote: >> On 2014/03/22 07:28, Richard W.M. Jones wrote: >> > >> > What's a good place to send trivial compiler patches? I don't want to >> > open a new bug for what is essentially a one-line aarch64 fix. >> >> You should. It would save you the time spent asking this question :-) >> More seriously, in theory all bug fixes should be tracked, even trivial >> ones, since it lets others know where they were fixed (and where not). > > Let me tell you how ordinary open source projects operate. > > (1) They use git. No one uses svn. > > (2) There is usually a mailing list where patches are posted, > discussed and refined. For example: > > https://lists.gnu.org/archive/html/qemu-devel/2014-03/threads.html > > (3) There may be another path for trivial fixes to get into the > project, eg. for typos, obvious build fixes, whitespace changes and so > on. In qemu this is: > > http://wiki.qemu.org/Contribute/TrivialPatches > https://lists.nongnu.org/mailman/listinfo/qemu-trivial > > This encourages people not to give up on simple fixes because of > excessive process. > > (4) They use a decent bug tracking system (ie. not Mantis). > > Rich. > > -- > Richard Jones > Red Hat > > -- > Caml-list mailing list. Subscription management and archives: > https://sympa.inria.fr/sympa/arc/caml-list > Beginner's list: http://groups.yahoo.com/group/ocaml_beginners > Bug reports: http://caml.inria.fr/bin/caml-bugs