caml-list - the Caml user's mailing list
 help / color / mirror / Atom feed
From: Gabriel Scherer <gabriel.scherer@gmail.com>
To: Josh Watzman <jwatzman@fb.com>
Cc: "caml-list@inria.fr" <caml-list@inria.fr>
Subject: Re: [Caml-list] ocamldebug improvement patches
Date: Fri, 10 Jan 2014 20:22:01 +0100	[thread overview]
Message-ID: <CAPFanBFbuL7hzRHjdqU3-xgJp-ip-EBux4XT0uQ0EQ_4roSmoA@mail.gmail.com> (raw)
In-Reply-To: <B4EAAC15-58F1-4A73-848E-5758E1F48BA4@fb.com>

Note that a review does not need to be performed by someone with
commit access first (just as, in Linux kernel land, not only subsystem
maintainers comment on proposed patches). Doing an independent review
of a patch is in fact a good way to start contributing to the compiler
development.

On Fri, Jan 10, 2014 at 7:15 PM, Josh Watzman <jwatzman@fb.com> wrote:
> A few weeks ago, I submitted Mantis tickets including patches which I believe make ocamldebug much more usable for a human user. No one has reviewed or responded to them yet, and it was suggested I post here: would someone with commit access be so kind as to take a look at the patches, and either commit them if they are acceptable, or let me know if not so I can improve them and resubmit? I personally find the quirks in ocamldebug that these patches fix quite frustrating, and I would love to see the changes incorporated in upstream ocaml to improve both my own experience and the experience of others :)
>
> Relevant Mantis tickets:
> http://caml.inria.fr/mantis/view.php?id=6267
> http://caml.inria.fr/mantis/view.php?id=6270
>
> Thanks!
> Josh Watzman
>
>
> --
> Caml-list mailing list.  Subscription management and archives:
> https://sympa.inria.fr/sympa/arc/caml-list
> Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
> Bug reports: http://caml.inria.fr/bin/caml-bugs

  reply	other threads:[~2014-01-10 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-10 18:15 Josh Watzman
2014-01-10 19:22 ` Gabriel Scherer [this message]
2014-01-11 14:35   ` Adrien Nader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPFanBFbuL7hzRHjdqU3-xgJp-ip-EBux4XT0uQ0EQ_4roSmoA@mail.gmail.com \
    --to=gabriel.scherer@gmail.com \
    --cc=caml-list@inria.fr \
    --cc=jwatzman@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).