From: Gabriel Scherer <gabriel.scherer@gmail.com>
To: Benjamin Greenman <blg59@cornell.edu>
Cc: Oliver Bandel <oliver@first.in-berlin.de>,
OCaml mailing-list <caml-list@inria.fr>
Subject: Re: [Caml-list] With String.sub I need to catch "Bytes.sub" exception
Date: Sun, 14 Sep 2014 11:14:22 +0200 [thread overview]
Message-ID: <CAPFanBGCuW1u1Th23CqL2ngmXyKehK7y7H=XuGNz3umATg93Bg@mail.gmail.com> (raw)
In-Reply-To: <CAAtAoRqiMs+RP3CWZSa+_i6UU5sx76H0S=L=fgrceiSQt_gK6A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]
Even if it's not technically a regression against the specification as per
Benjamin's message above, breaking working code is still not very good.
Could you please report this on the OCaml bugtracker?
http://caml.inria.fr/mantis/
On Sun, Sep 14, 2014 at 12:53 AM, Benjamin Greenman <blg59@cornell.edu>
wrote:
> Why do you match on the error string? String.sub is only documented to
> raise "Invalid_argument _".
>
> http://caml.inria.fr/pub/docs/manual-ocaml/libref/String.html
>
> On Sat, Sep 13, 2014 at 6:47 PM, Oliver Bandel <oliver@first.in-berlin.de>
> wrote:
>
>> Hello,
>>
>> is this a known bug?
>>
>> Needed to change code from
>>
>> with Invalid_argument("Strings.sub")
>> to
>> with Invalid_argument("Bytes.sub")
>>
>> The code now looks like this and then works again:
>>
>>
>> try
>> if parser_url_len > 0 && parser_url = String.sub url
>> 0 parser_url_len then parser_name else aux tl
>> with Invalid_argument("Bytes.sub") -> aux tl (* this
>> happens if url is shorter than parser_url *)
>>
>>
>> Ciao,
>> Oliver
>>
>>
>> --
>> Caml-list mailing list. Subscription management and archives:
>> https://sympa.inria.fr/sympa/arc/caml-list
>> Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
>> Bug reports: http://caml.inria.fr/bin/caml-bugs
>>
>
>
[-- Attachment #2: Type: text/html, Size: 2600 bytes --]
next prev parent reply other threads:[~2014-09-14 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 22:47 Oliver Bandel
2014-09-13 22:53 ` Benjamin Greenman
2014-09-14 9:14 ` Gabriel Scherer [this message]
2014-09-14 15:18 ` Oliver Bandel
2014-09-14 15:19 ` Oliver Bandel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPFanBGCuW1u1Th23CqL2ngmXyKehK7y7H=XuGNz3umATg93Bg@mail.gmail.com' \
--to=gabriel.scherer@gmail.com \
--cc=blg59@cornell.edu \
--cc=caml-list@inria.fr \
--cc=oliver@first.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).