From: Gabriel Scherer <gabriel.scherer@gmail.com>
To: "Stéphane Glondu" <steph@glondu.net>
Cc: Olaf Hering <olaf@aepfle.de>, caml users <caml-list@inria.fr>
Subject: Re: [Caml-list] removal of C compiler variables in in 4.06
Date: Tue, 18 Jul 2017 08:24:53 -0400 [thread overview]
Message-ID: <CAPFanBGM-O9qdyxg1kT5JSA_+sC2A+p3m+OXwZ0WGJbTgcv=hw@mail.gmail.com> (raw)
In-Reply-To: <f55864cf-36f0-6e88-25d5-d1e6e13deb57@glondu.net>
The BYTECC and NATIVECC variables are still present in 4.05 (the last
release), they are gone in 4.06 (the in-development version). Olaf
mentions that this requires a change to the labltk build system, but
the change should not affect 4.05.
Stéphane, in your patches, it looks to me like you apply the
4.06-required change in 0001-Fix-for-ocaml-4.06.patch, and then you
cancel them in 0003-CC-variable-does-not-exist-in-4.05.0-s-Makefile.conf.patch
to go back to the unchanged state. Could you apply none of them
instead? (It does not help that there is an unrelated change in
0001-..-4.06.patch, it would be nicer to have two separate patches.)
Note that your patch 0002-Fix-calls-to-caml_-functions.patch is very
nice (use of the caml_ prefix for C runtime functions, the unprefixed
functions being deprecated and disabled by default), you should
definitely submit it upstream.
On Tue, Jul 18, 2017 at 7:37 AM, Stéphane Glondu <steph@glondu.net> wrote:
> On 18/07/2017 11:02, Olaf Hering wrote:
>>
>> While wresting with labltk and 4.05 [...]
>
>
> FYI, I've fixed labltk with 4.05 in the Debian package (not yet uploaded):
>
>
> https://anonscm.debian.org/cgit/pkg-ocaml-maint/packages/labltk.git/tree/debian/patches
>
> Maybe you can double-check and submit upstream?
>
>
> Cheers,
>
> --
> Stéphane
>
>
> --
> Caml-list mailing list. Subscription management and archives:
> https://sympa.inria.fr/sympa/arc/caml-list
> Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
> Bug reports: http://caml.inria.fr/bin/caml-bugs
next prev parent reply other threads:[~2017-07-18 12:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 9:02 Olaf Hering
2017-07-18 9:23 ` Adrien Nader
2017-07-18 13:31 ` Olaf Hering
2017-07-18 11:37 ` Stéphane Glondu
2017-07-18 12:24 ` Gabriel Scherer [this message]
2017-07-18 12:59 ` Stéphane Glondu
2017-07-18 13:41 ` Olaf Hering
2017-07-18 13:49 ` Gabriel Scherer
2017-07-18 18:04 ` Olaf Hering
2017-07-18 13:28 ` Jesper Louis Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPFanBGM-O9qdyxg1kT5JSA_+sC2A+p3m+OXwZ0WGJbTgcv=hw@mail.gmail.com' \
--to=gabriel.scherer@gmail.com \
--cc=caml-list@inria.fr \
--cc=olaf@aepfle.de \
--cc=steph@glondu.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).