From: Jordan W <jordojw@gmail.com>
To: "caml-list@inria.fr" <caml-list@inria.fr>
Subject: [Caml-list] Option to have source code printer also print comments.
Date: Mon, 2 Feb 2015 20:58:25 -0800 [thread overview]
Message-ID: <CAPOA5_7yMa2=kqvcWCYP3SsQ1+G2WE+J5ja6dPFsxF7+XCbXFw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
Comments are nicely tracked in `last_comments` within `lexer.ml`. I think
it would be nice to have `compile.ml` pass these comments to the source
code pretty printer. I wouldn't mind if it always printed comments or if
there were another flag to control whether or not comments were printed.
The work to plumb the comments to the pretty printer is pretty trivial and
I'm happy to send a pull request. Actually printing the comments is easy
but requires a ton of tedious changes to the pretty printer. It makes sense
to make the pretty printer more customizable, and just having the comments
accessible at that point seems like a good idea.
Would the pull request to plumb the comments to the pretty printer be
likely to be accepted?
[-- Attachment #2: Type: text/html, Size: 850 bytes --]
reply other threads:[~2015-02-03 4:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPOA5_7yMa2=kqvcWCYP3SsQ1+G2WE+J5ja6dPFsxF7+XCbXFw@mail.gmail.com' \
--to=jordojw@gmail.com \
--cc=caml-list@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).