From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by sympa.inria.fr (Postfix) with ESMTPS id 7BD547F6CC for ; Tue, 3 Feb 2015 05:58:27 +0100 (CET) Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of jordojw@gmail.com) identity=pra; client-ip=209.85.215.52; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="jordojw@gmail.com"; x-sender="jordojw@gmail.com"; x-conformance=sidf_compatible Received-SPF: Pass (mail2-smtp-roc.national.inria.fr: domain of jordojw@gmail.com designates 209.85.215.52 as permitted sender) identity=mailfrom; client-ip=209.85.215.52; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="jordojw@gmail.com"; x-sender="jordojw@gmail.com"; x-conformance=sidf_compatible; x-record-type="v=spf1" Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@mail-la0-f52.google.com) identity=helo; client-ip=209.85.215.52; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="jordojw@gmail.com"; x-sender="postmaster@mail-la0-f52.google.com"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CUAQC6VNBUlDTXVdFag1hZBIJ9wBmBYYcVB0MBAQEBAREBAQEBBwsLCRIwhAMiER0BGx4DEggBBzcCJAERAQUBIjWHdgEDEa99gys+MYsugWuCd4sGChknDVSFQgEFDpJZgUEFihuIPIVXgU2LFIQxEiOBDAmEMR0xgkIBAQE X-IPAS-Result: A0CUAQC6VNBUlDTXVdFag1hZBIJ9wBmBYYcVB0MBAQEBAREBAQEBBwsLCRIwhAMiER0BGx4DEggBBzcCJAERAQUBIjWHdgEDEa99gys+MYsugWuCd4sGChknDVSFQgEFDpJZgUEFihuIPIVXgU2LFIQxEiOBDAmEMR0xgkIBAQE X-IronPort-AV: E=Sophos;i="5.09,510,1418079600"; d="scan'208";a="119959026" Received: from mail-la0-f52.google.com ([209.85.215.52]) by mail2-smtp-roc.national.inria.fr with ESMTP/TLS/RC4-SHA; 03 Feb 2015 05:58:26 +0100 Received: by mail-la0-f52.google.com with SMTP id ge10so48016313lab.11 for ; Mon, 02 Feb 2015 20:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=mLRHXYtcQpojyDm6zdL8bWrLxLoLG+oqvwz49Zu20DM=; b=TjvVr5mqPgX6AFcMStCpQONaEpGDlTFJ8rpxMESUPvJnTQ5HagNu/JRIoTnqmtZ6U+ y+kGpgW/2aCIDCPbCdY6nrAsxoNKPZvriAOCw+e9hyPZEtaDgBoJe7oC4vJaP6xera+p Pb9sfZg6184lthHNpFghISjjGRby/moWc/ILW0RGEK5nkB8oDSBBZ/M6j2shZMwRO6Cr YFEai3xT7EYXRFZydUupqRLq5qwKV0yEvHGUjpa5ZlGyW9H0DKdh8PFA0tM7nrn6NJQN ww6xUTkfvNmmKdCBvCvZtuSXoEJTvV8v8q+dUHPdY5lTM0qbLsZO/pwfPppcObFHWLoR 3KRA== MIME-Version: 1.0 X-Received: by 10.112.185.101 with SMTP id fb5mr22814503lbc.12.1422939505924; Mon, 02 Feb 2015 20:58:25 -0800 (PST) Received: by 10.25.207.143 with HTTP; Mon, 2 Feb 2015 20:58:25 -0800 (PST) Date: Mon, 2 Feb 2015 20:58:25 -0800 Message-ID: From: Jordan W To: "caml-list@inria.fr" Content-Type: multipart/alternative; boundary=001a11c3c516c99e0c050e27ebbc X-Validation-by: jordojw@gmail.com Subject: [Caml-list] Option to have source code printer also print comments. --001a11c3c516c99e0c050e27ebbc Content-Type: text/plain; charset=UTF-8 Comments are nicely tracked in `last_comments` within `lexer.ml`. I think it would be nice to have `compile.ml` pass these comments to the source code pretty printer. I wouldn't mind if it always printed comments or if there were another flag to control whether or not comments were printed. The work to plumb the comments to the pretty printer is pretty trivial and I'm happy to send a pull request. Actually printing the comments is easy but requires a ton of tedious changes to the pretty printer. It makes sense to make the pretty printer more customizable, and just having the comments accessible at that point seems like a good idea. Would the pull request to plumb the comments to the pretty printer be likely to be accepted? --001a11c3c516c99e0c050e27ebbc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Comments are nicely tracked in `last_comments` within `lexer.ml`. I think it would be nice to have `<= a href=3D"http://compile.ml">compile.ml` pass these comments to the sou= rce code pretty printer. I wouldn't mind if it always printed comments = or if there were another flag to control whether or not comments were print= ed. The work to plumb the comments to the pretty printer is pretty trivial = and I'm happy to send a pull request. Actually printing the comments is= easy but requires a ton of tedious changes to the pretty printer. It makes= sense to make the pretty printer more customizable, and just having the co= mments accessible at that point seems like a good idea.

= Would the pull request to plumb the comments to the pretty printer be likel= y to be accepted?
--001a11c3c516c99e0c050e27ebbc--