caml-list - the Caml user's mailing list
 help / color / mirror / Atom feed
From: Markus Mottl <markus.mottl@gmail.com>
To: Damien Doligez <damien.doligez@inria.fr>
Cc: caml users <caml-list@inria.fr>
Subject: Re: [Caml-list] RFC: basename, dirname, PR#4549
Date: Tue, 27 Dec 2011 13:36:07 -0500	[thread overview]
Message-ID: <CAP_800oJEXU45mLzsM-Y6nh-O4U5oXDNH=eP9Of-DBH9ZvAGzg@mail.gmail.com> (raw)
In-Reply-To: <CEA65716-7575-4071-8A73-71D5E61C721C@inria.fr>

Hi,

I think the difference will mostly matter for code only that requires
human input of paths, whether in a prompt or through a configuration
file, and even there it would be rather unlikely to encounter such
paths.  Big deal, users can change their input easily.  Having done my
fair share of path mangling, I guess most applications that generate
paths internally only, e.g. to walk through a directory hierarchy, are
safe.  It would seem highly unusual that anybody added an extra slash
in code accessing files within a program.  I personally prefer
standard conformance.

Regards,
Markus

On Tue, Dec 27, 2011 at 11:29, Damien Doligez <damien.doligez@inria.fr> wrote:
> Hello,
>
> I would like to get some comments from the OCaml community at large about
> the problem raised in http://caml.inria.fr/mantis/view.php?id=4549
>
> In a nutshell, the problem is that our version of basename and dirname
> are not exactly the same as the Open Group's definition.
>
> We can easily implement the standard behaviour for basename and dirname,
> and it seems desirable, but there is a catch: we will have to change
> the specification of the standard library slightly.
>
> Currently, we specify this:
>
>   [concat (dirname name) (basename name)] returns a file name
>   which is equivalent to [name]. Moreover, after setting the
>   current directory to [dirname name] (with {!Sys.chdir}),
>   references to [basename name] (which is a relative file name)
>   designate the same file as [name] before the call to {!Sys.chdir}.
>
> With the Open Group basename and dirname, this becomes false for
> names that include some trailing slashes, because such slashes
> are removed by basename.  This means that a name "foo/bar/"
> becomes "foo/bar" when put through
>  [concat (dirname name) (basename name)]
> and opening "foo/bar" may succeed if it is a file, while
> opening "foo/bar/" would fail.
>
> I would like to know if anyone relies on the precise behaviour
> documented in the standard library, and for everyone else, would
> you prefer the old behaviour or the new (standard) behaviour?
>
> -- Damien
>
>
> --
> Caml-list mailing list.  Subscription management and archives:
> https://sympa-roc.inria.fr/wws/info/caml-list
> Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
> Bug reports: http://caml.inria.fr/bin/caml-bugs
>



-- 
Markus Mottl        http://www.ocaml.info        markus.mottl@gmail.com


  parent reply	other threads:[~2011-12-27 18:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-27 16:29 Damien Doligez
2011-12-27 17:37 ` Daniel Bünzli
2011-12-27 18:36 ` Markus Mottl [this message]
2011-12-27 19:42 ` Gerd Stolpmann
2011-12-28  4:50   ` Till Varoquaux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP_800oJEXU45mLzsM-Y6nh-O4U5oXDNH=eP9Of-DBH9ZvAGzg@mail.gmail.com' \
    --to=markus.mottl@gmail.com \
    --cc=caml-list@inria.fr \
    --cc=damien.doligez@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).