Re: [Caml-list] modified error messages for ocamlc

["Daniel Bünzli" <daniel.buenzli@erratique.ch>]

Le dimanche, 21 avril 2013 à 08:37, Gabriel Scherer a écrit :

> I think a patch affecting the error and warning-printing functions of
> the Location module (parsing/location.ml) should be a very satisfying
> first step (what kind of errors are you thinking about that aren't
> handled by these functions?). I'm considering writing such a patch.

Stacktraces in printexc.ml are an example (OT but if you are changing things in printexc could maybe grant the whish of that comment [1]...). There are quite a few places, see the end of this email for an over approximation of the places to change.

Also please make sure to update caml.el so that it works. Should be mainly about the caml-error-regexp, caml-error-chars-regexp constants. Maybe, because of the standardization it's actually just a matter of removing the addition made to compilation-error-regexp-alist.  

Best,

Daniel

[1] http://caml.inria.fr/mantis/view.php?id=5899#c8779


> git grep "\"File"
asmcomp/asmpackager.ml: fprintf ppf "File %a@ was not compiled with the `-for-pack %s' option"
asmcomp/asmpackager.ml: fprintf ppf "File %s not found" file
bytecomp/bytepackager.ml: fprintf ppf "File %a redefines %s"
bytecomp/bytepackager.ml: fprintf ppf "File %s not found" file
camlp4/Camlp4/Struct/Loc.ml: let res = sprintf "File \"%s\", line %d, characters %d-%d"
camlp4/boot/Camlp4.ml: sprintf "File \"%s\", line %d, characters %d-%d" x.file_name
debugger/loadprinter.ml: fprintf ppf "File %s loaded@." filename;
experimental/doligez/checkheaders: printf ("File \"%s\", line %d:\n", FILENAME, FNR);
lex/main.ml: "File \"%s\", line %d, character %d: character set expected.\n"
lex/main.ml: "File \"%s\", line %d, character %d: syntax error.\n"
lex/main.ml: "File \"%s\", line %d, character %d: %s.\n"
lex/main.ml: "File \"%s\":\n Position memory overflow, too many bindings\n"
lex/main.ml: "File \"%s\":\ntransition table overflow, automaton is too big\n"
lex/parser.mly: Printf.eprintf "File \"%s\", line %d, character %d:\n\
ocamlbuild/configuration.ml: parse_lexbuf ?dir (Printf.sprintf "File %S" file) (Lexing.from_channel ic)
ocamlbuild/hygiene.ml: Some(sf "File %s in %s has suffix %s" name path suffix)
ocamlbuild/hygiene.ml: Some(sf "Files %s and %s should not be together in %s" name name' path)
ocamlbuild/testsuite/level0.ml: ["*:a", "File \"_tags\", line 1, column 0: Lexing error: Invalid globbing pattern \"*\".";
ocamlbuild/testsuite/level0.ml: "\n<*{>:a", "File \"_tags\", line 2, column 0: Lexing error: Invalid globbing pattern \"<*{>\".";
ocamlbuild/testsuite/level0.ml: "<*>: ~@a,# ~a", "File \"_tags\", line 1, column 10: Lexing error: Only ',' separated tags are alllowed."];;
ocamldoc/odoc_messages.ml:let file_generated f = "File "^f^" generated."
ocamldoc/odoc_messages.ml: "File "^f^" exists, we don't generate it."
otherlibs/dynlink/dynlink.ml: Printf.sprintf "File_not_found %S" s
otherlibs/labltk/browser/editor.ml: val file_menu = new Jg_menu.c "File" ~parent:menus
otherlibs/labltk/browser/editor.ml: ("File `" ^ name ^ "' exists. Overwrite it?")
otherlibs/labltk/browser/fileselect.ml: let dfrl = Label.create dfr ~text:"Files" in
otherlibs/labltk/browser/shell.ml: let file_menu = new Jg_menu.c "File" ~parent:menus
otherlibs/labltk/browser/viewer.ml: let filemenu = new Jg_menu.c "File" ~parent:menus
otherlibs/labltk/browser/viewer.ml: let filemenu = new Jg_menu.c "File" ~parent:menus
otherlibs/labltk/compiler/maincompile.ml: prerr_string "File \""; prerr_string !input_name;
otherlibs/labltk/examples_camltk/fileopen.ml:let t = Label.create cvs [Text "File name"];;
otherlibs/labltk/examples_camltk/winskel.ml: let file = Menubutton.create mbar [Text "File"; UnderlinedChar 0]
otherlibs/labltk/jpf/fileselect.ml: let dfrl = Label.create dfr ~text: "Files" in
parsing/location.ml: ("File \"", "\", line ", ", characters ", "-", ":")
stdlib/filename.ml: if n < 0 then invalid_arg "Filename.chop_suffix" else String.sub name 0 n
stdlib/filename.ml: if i < 0 || is_dir_sep name i then invalid_arg "Filename.chop_extension"
stdlib/printexc.ml:let locfmt = format_of_string "File \"%s\", line %d, characters %d-%d: %s";;
testsuite/Makefile: @if [ ! -f $(FILE) ]; then echo "File '$(FILE)' does not exist."; exit 1; fi
tools/cmt2annot.ml: Printf.fprintf stderr "File was generated with an error\n%!";
tools/cmt2annot.ml: Printf.fprintf stderr "File was generated with an error\n%!";
tools/dumpobj.ml: printf "File \"%s\", line %d, characters %d-%d:\n" ls.Lexing.pos_fname
tools/objinfo.ml: printf "File %s\n" filename;
tools/scrapelabels.ml: "Event"; "Filename"; "Format"; "Gc"; "Genlex"; "Graphics";
toplevel/opttopdirs.ml: | None -> fprintf ppf "File not found: %s@." name0; false
toplevel/topdirs.ml: fprintf ppf "File %s is not a bytecode object file.@." name;
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: unexpected end-of-file\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: syntax error\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: unmatched /*\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: unterminated string\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: unmatched %%{\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: unterminated %%union declaration\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: too many %%union declarations\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: illegal tag\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: illegal character\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: illegal use of reserved symbol \
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: the start symbol `%s' cannot \
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: warning: the type of `%s' has been \
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: warning: the precedence of `%s' has \
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: warning: the value of `%s' has been \
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: the entry point `%s' is a \
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: more than 256 entry points\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: no grammar has been specified\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: a token appears on the lhs \
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: warning: conflicting %%prec \
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: unterminated action\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: warning: $%d references beyond the \
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: illegal $-name\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: $$ is untyped\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: $%d (%s) is untyped\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: $%d is unbound\n",
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: $%d refers to terminal `%s', \
yacc/error.c: fprintf(stderr, "File \"%s\", line %d: no action specified for this \