From: Will M Farr <farr@MIT.EDU>
To: caml-list@inria.fr
Subject: Optimizing Float Ref's
Date: Fri, 28 Aug 2009 15:32:55 -0500 [thread overview]
Message-ID: <D3041D62-4F8D-4121-8CEF-5EE810D8FFA6@MIT.EDU> (raw)
[-- Attachment #1: Type: text/plain, Size: 2014 bytes --]
Hello all,
I'm running OCaml 3.11.1, and I noticed something strange in some
native code for matrix multiply today. The code was
let mmmul store m1 m2 =
let (ni,nk) = dims m1 and
(nk2,nj) = dims m2 and
(sni,snj) = dims store in
assert(nk=nk2);
assert(ni=sni);
assert(nj=snj);
for i = 0 to ni - 1 do
let row1 = m1.(i) and
srow = store.(i) in
for j = 0 to nj - 1 do
let sum = ref 0.0 in (* Un-boxed float ref? *)
for k = 0 to nk - 1 do
let row2 = Array.unsafe_get m2 k in
let x = Array.unsafe_get row1 k and
y = Array.unsafe_get row2 j in
sum := !sum +. x*.y
done;
Array.unsafe_set srow j !sum
done
done;
store
(I compiled with ocamlopt.) It multiplies the matrices (represented
as arrays of arrays of floats) m1 and m2 together and puts the result
into the matrix store. Profiling the code, I noticed a call to
caml_modify during the execution of this function! Turns out that the
culprit was the float ref "sum". Changing to the following code
(which eliminates the float ref, and uses the <- and .( ) operators
instead of unsafe_set and unsafe_get) eliminated that call, and sped
things up tremendously:
let mmmul store m1 m2 =
let (ni,nk) = dims m1 and
(nk2,nj) = dims m2 in
for i = 0 to ni - 1 do
let row1 = m1.(i) and
srow = store.(i) in
for j = 0 to nj - 1 do
srow.(j) <- 0.0;
for k = 0 to nk - 1 do
let row2 = Array.unsafe_get m2 k in
let x = row1.(k) and
y = row2.(j) in
srow.(j) <- srow.(j) +. x*.y
done
done
done;
store
But, I thought that float ref's were automatically unboxed by the
compiler when they didn't escape the local context. Is this a
complier bug, is there a bad interaction with unsafe_get and
unsafe_set, or is there something else going on that I don't
understand? Any enlightenment would be appreciated.
Thanks!
Will
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 203 bytes --]
next reply other threads:[~2009-08-28 20:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 20:32 Will M Farr [this message]
2009-08-30 19:43 ` [Caml-list] " Yaron Minsky
2009-08-31 14:09 ` Till Varoquaux
2009-08-31 14:51 ` Will M Farr
2009-08-31 17:30 ` Jon Harrop
2009-08-31 17:15 ` Jon Harrop
2009-09-03 9:44 ` Xavier Leroy
2009-09-03 10:15 ` Will M Farr
2010-03-31 17:21 ` Dmitry Bely
[not found] ` <p2tc7e4e9f1003311055xce0919wac2118aa3c05f1cb@mail.gmail.com>
2010-03-31 18:28 ` Dmitry Bely
2010-03-31 18:59 ` Alain Frisch
2010-03-31 19:18 ` Dmitry Bely
[not found] ` <m2lfbd71dab1003311252v5bda5d13vc2146d2d24270847@mail.gmail.com>
2010-03-31 20:00 ` Dmitry Bely
2010-04-14 18:13 ` Goswin von Brederlow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D3041D62-4F8D-4121-8CEF-5EE810D8FFA6@MIT.EDU \
--to=farr@mit.edu \
--cc=caml-list@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).