From: Thomas Fischbacher <Thomas.Fischbacher@Physik.Uni-Muenchen.DE>
To: Remi Vanicat <remi.vanicat@laposte.net>
Cc: caml-list@inria.fr
Subject: Re: [Caml-list] Hashtbl and destructive operations on keys
Date: Tue, 23 Mar 2004 00:13:14 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.58.0403222348530.30579@seekar.cip.physik.uni-muenchen.de> (raw)
In-Reply-To: <871xnky9zk.dlv@vanicat.homelinux.org>
On Mon, 22 Mar 2004, Remi Vanicat wrote:
> > So, could I please get this officially sanctioned? :-)
>
> This is not an official answers, but it is what ocaml tell me :
>
> # let tbl = create 10;;
> val tbl : ('_a, '_b) Hashtbl.t = <abstr>
> # let r = ref 10;;
> val r : int ref = {contents = 10}
> # replace tbl r 50;;
> - : unit = ()
> # r := 1;;
> - : unit = ()
> # find tbl r;;
> Exception: Not_found.
Please look closely at my original posting. This is not what I was
intending to do.
What I rather want to do is roughly along the following lines:
let nonconsing_accum f_combine f_copy ht h_key h_val =
if Hashtbl.mem ht h_key
then Hashtbl.replace ht h_key
(f_combine (Hashtbl.find ht h_key) h_val)
else Hashtbl.add ht (f_copy h_key) h_val
;;
let result =
(
let ht = Hashtbl.create 10 in
let arr = Array.make 4 0 in
for i = 0 to 1000 do
for k = 0 to 4-1 do
arr.(k) <- Random.int 5;
done;
nonconsing_accum (+) Array.copy ht arr 1;
done;
Hashtbl.fold (fun k v so_far -> (k,v)::so_far) ht [];
)
;;
Former experience with CMU CL tells me that this technique of not
unnecessarily consing hash keys can easily lead to a performance gain of
a factor of 10 - depending on the application, of course.
But I have a very bad feeling about it as long as I do not have any
guarantee that I really can re-use the corpus of a hash key passed to
Hashtbl.replace.
Yes, one answer certainly is "just make the hash value a ref and work on
its contents". But there are indeed some crazy situations where one is
better off using the above technique.
--
regards, tf@cip.physik.uni-muenchen.de (o_
Thomas Fischbacher - http://www.cip.physik.uni-muenchen.de/~tf //\
(lambda (n) ((lambda (p q r) (p p q r)) (lambda (g x y) V_/_
(if (= x 0) y (g g (- x 1) (* x y)))) n 1)) (Debian GNU)
-------------------
To unsubscribe, mail caml-list-request@inria.fr Archives: http://caml.inria.fr
Bug reports: http://caml.inria.fr/bin/caml-bugs FAQ: http://caml.inria.fr/FAQ/
Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
next prev parent reply other threads:[~2004-03-22 23:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-22 18:16 Thomas Fischbacher
2004-03-22 19:09 ` Remi Vanicat
2004-03-22 23:13 ` Thomas Fischbacher [this message]
2004-03-23 0:59 ` Jacques Garrigue
2004-03-23 9:20 ` Correnson Loïc
2004-03-23 12:12 ` Thomas Fischbacher
2004-03-23 9:45 ` Oliver Bandel
2004-03-22 23:44 Oliver Bandel
2004-03-22 23:44 Oliver Bandel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0403222348530.30579@seekar.cip.physik.uni-muenchen.de \
--to=thomas.fischbacher@physik.uni-muenchen.de \
--cc=caml-list@inria.fr \
--cc=remi.vanicat@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).