From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@yquem.inria.fr Delivered-To: caml-list@yquem.inria.fr Received: from mail1-relais-roc.national.inria.fr (mail1-relais-roc.national.inria.fr [192.134.164.82]) by yquem.inria.fr (Postfix) with ESMTP id 14980BC57 for ; Sat, 12 Jun 2010 22:54:45 +0200 (CEST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvQFAD6RE0xN6B+ka2dsb2JhbACfFw0ICwkzvWyFGgSDSA X-IronPort-AV: E=Sophos;i="4.53,408,1272837600"; d="scan'208";a="61192624" Received: from fe01x03-cgp.akado.ru (HELO akado.ru) ([77.232.31.164]) by mail1-smtp-roc.national.inria.fr with ESMTP; 12 Jun 2010 22:54:44 +0200 Received: from [10.0.66.9] ([10.0.66.9] verified) by fe01-cgp.akado.ru (CommuniGate Pro SMTP 5.2.13) with ESMTPS id 191533502; Sun, 13 Jun 2010 00:54:44 +0400 Date: Sun, 13 Jun 2010 00:54:36 +0400 (MSD) From: malc X-X-Sender: malc@linmac To: =?ISO-8859-15?Q?T=F6r=F6k_Edwin?= Cc: caml-list@yquem.inria.fr Subject: Re: [Caml-list] [ANNOUNCE] llpp In-Reply-To: <4C13F2F1.9070508@gmail.com> Message-ID: References: <4C13F2F1.9070508@gmail.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam: no; 0.00; malc:01 malc:01 usr:01 segfaults:01 printf:01 edwin:98 git:98 git:98 wrote:01 wrote:01 compile:01 typing:01 caml-list:01 minor:01 short:01 On Sat, 12 Jun 2010, T?r?k Edwin wrote: > On 06/12/2010 09:36 PM, malc wrote: > > Hello, > > > > Long story cut short: the PDF viewers that are available for my machine > > leave a lot to be desired for my usage pattern, so i had to write yet > > another, the code is at: > > > > http://repo.or.cz/w/llpp.git > > > > http://repo.or.cz/w/llpp.git/blob_plain/master:/BUILDING explains how to > > build it. > > > > Appears to be working fine so far, and much faster than okular. > > Two minor issues: > 1. The mupdf from sumatrapdf installs fitz.h and mupdf.h directly into > /usr/local/include, and not under fitz/, or mupdf/, so llpp failed to > compile. I fixed by copying the headers to where llpp expected them to be. I was a nanometer away from typing: please edit build.sh to match your mupdf installation(or lack there of) into BUILDING, but then didn't, sigh... > 2. It segfaults if the file is not found, fix below: > diff --git a/link.c b/link.c > index 7ca7684..7dab233 100644 > --- a/link.c > +++ b/link.c > @@ -177,7 +177,8 @@ static void __attribute__ ((format (printf, 2, 3))) > static void die (fz_error error) > { > fz_catch (error, "aborting"); > - pdf_closexref (state.xref); > + if (state.xref) > + pdf_closexref (state.xref); > exit (1); > } > Thank you. -- mailto:av1474@comtv.ru