From: "Clément Franchini" <cfranchini@altair.com>
To: "caml-list@inria.fr" <caml-list@inria.fr>
Subject: Re: [Caml-list] Support de l'UTF16
Date: Mon, 29 May 2017 10:30:36 +0200 [thread overview]
Message-ID: <bb7edc02-0aa9-3b03-533f-e26443ae732f@altair.com> (raw)
In-Reply-To: <E51C5B015DBD1348A1D85763337FB6D90135D73BCC@Remus.metastack.local>
Hi,
sorry for my first mail in French.
> or a completely new one (see also https://github.com/ocaml/ocaml/pull/153
It's that pull request, but the 8 commits are merged/squashed into one.
And I had to change a big part of it, because the OCaml compiler has
evolved since 4.02.3. It was not a trivial rebase, the initial patch
need some work to be rebased.
> GitHub pull request
Today I don't know if I can have a github account. with my professional
email. I asked if I can, I'm waiting the answer.
Regards.
--
Clément Franchini
On 2017-05-24 18:02, David Allsopp wrote:
> Clément Franchini wrote:
>> Bonjour.
>> J'écris suite à mon message sur le ticket
>> https://caml.inria.fr/mantis/view.php?id=3771
>>
>> J'ai passé pas mal de temps sur le support des chemins de fichier en
>> utf16 sous NT. J'ai déjà soumis trois patchs (en fonction du commit sur
>> lequel on veut appliquer le patch).
>>
>> Nous, Altair, sommes intéressés par l'intégration de ce commit/patch dans
>> OCaml. L'idéal serait une intégration dans la branche 4.04, mais je ne
>> pense pas que cela soit possible.
>>
>> Ce n'est pas un petit commit, il nécessite d'être revu. J'écris ce mail
>> pour faire avancer les choses. Nous y avons grand intérêt.
>>
>> Cordialement/Regards.
>
> I saw the patch arrive last week, but I'm afraid I hadn't had a chance to look into it. Is this patch a rebase of the existing ones on that Mantis PR, or a completely new one (see also https://github.com/ocaml/ocaml/pull/153)?
>
> It's not compulsory, but it might be easier to review this as a GitHub pull request. It's fine to be working on trunk only for this change - I'm afraid it's very unlikely that it would be officially back-ported to 4.04 or 4.05.
>
>
> David
>
prev parent reply other threads:[~2017-05-29 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 15:55 Clément Franchini
2017-05-24 16:02 ` David Allsopp
2017-05-29 8:30 ` Clément Franchini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb7edc02-0aa9-3b03-533f-e26443ae732f@altair.com \
--to=cfranchini@altair.com \
--cc=caml-list@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).