camlp4 3.10: What should this look like?

camlp4 3.10: What should this look like?

[Joel Reymont]

What should this look like in the new camlp4 syntax?

EXTEND
   Pcaml.expr: LEVEL "expr1" [
     [ "PGSQL"; "("; dbh = Pcaml.expr; ")"; extras = LIST1 STRING ->
         let query, flags =
           match List.rev extras with
           | [] -> assert false
           | query :: flags -> query, flags in
         pgsql_expand ~flags loc dbh (Token.eval_string loc query)
     ]
   ];
END

	Thanks, Joel

--
http://wagerlabs.com/

Re: [Caml-list] camlp4 3.10: What should this look like?

[Nicolas Pouillard]

On 5/21/07, Joel Reymont <joelr1@gmail.com> wrote:
> What should this look like in the new camlp4 syntax?

Something like (not tested):

open Camlp4.PreCast;;
open Syntax;;
EXTEND Gram
   expr: LEVEL "top" [
     [ "PGSQL"; "("; dbh = expr; ")"; extras = LIST1 STRING ->
         let query, flags =
           match List.rev extras with
           | [] -> assert false
           | query :: flags -> query, flags in
         pgsql_expand ~flags loc dbh (Camlp4.Struct.Token.Eval.string query)
     ]
   ];
END

-- 
Nicolas Pouillard

Re: [Caml-list] camlp4 3.10: What should this look like?

[Joel Reymont]

On May 21, 2007, at 10:26 AM, Nicolas Pouillard wrote:

>     [ "PGSQL"; "("; dbh = expr; ")"; extras = LIST1 STRING ->

It appears to want the following, please let me know if it's wrong.

     [ "PGSQL"; "("; dbh = expr; ")"; extras = LIST1 [ x = STRING ->  
x ] ->

A follow up question... What has become of Stdpp.raise_with_loc, as  
in the following?

         Stdpp.raise_with_loc loc (
           Failure ("Unknown flag: " ^ str)
         )

	Thanks, Joel

--
http://wagerlabs.com/

Re: [Caml-list] camlp4 3.10: What should this look like?

[Nicolas Pouillard]

On 5/21/07, Joel Reymont <joelr1@gmail.com> wrote:
>
> On May 21, 2007, at 10:26 AM, Nicolas Pouillard wrote:
>
> >     [ "PGSQL"; "("; dbh = expr; ")"; extras = LIST1 STRING ->
>
> It appears to want the following, please let me know if it's wrong.
>
>      [ "PGSQL"; "("; dbh = expr; ")"; extras = LIST1 [ x = STRING ->
> x ] ->
>

You're right.

> A follow up question... What has become of Stdpp.raise_with_loc, as
> in the following?
>
>          Stdpp.raise_with_loc loc (
>            Failure ("Unknown flag: " ^ str)
>          )
>

Loc.raise

-- 
Nicolas Pouillard