From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by c5ff346549e7 (Postfix) with ESMTPS id B66F35D4 for ; Thu, 10 May 2018 07:00:55 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.49,384,1520895600"; d="scan'208";a="326368664" Received: from sympa.inria.fr ([193.51.193.213]) by mail2-relais-roc.national.inria.fr with ESMTP; 10 May 2018 09:00:28 +0200 Received: by sympa.inria.fr (Postfix, from userid 20132) id 462C28240C; Thu, 10 May 2018 09:00:28 +0200 (CEST) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sympa.inria.fr (Postfix) with ESMTPS id 307E18240C for ; Thu, 10 May 2018 09:00:21 +0200 (CEST) Authentication-Results: mail3-smtp-sop.national.inria.fr; spf=None smtp.pra=rudi.grinberg@gmail.com; spf=Pass smtp.mailfrom=rudi.grinberg@gmail.com; spf=None smtp.helo=postmaster@mail-pf0-f180.google.com IronPort-PHdr: =?us-ascii?q?9a23=3AkQHZ6BV0kFxri4dYi4uATJx/5j7V8LGtZVwlr6E/?= =?us-ascii?q?grcLSJyIuqrYbB2Ft8tkgFKBZ4jH8fUM07OQ7/i7HzRYqb+681k6OKRWUBEEjc?= =?us-ascii?q?hE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i764jEdAAjwOhRo?= =?us-ascii?q?LerpBIHSk9631+ev8JHPfglEnjWwba98IRmssQndqtQdjJd/JKo21hbHuGZDdf?= =?us-ascii?q?5MxWNvK1KTnhL86dm18ZV+7SleuO8v+tBZX6nicKs2UbJXDDI9M2Ao/8LrrgXM?= =?us-ascii?q?TRGO5nQHTGoblAdDDhXf4xH7WpfxtTb6tvZ41SKHM8D6Uaw4VDK/5KpwVhTmlD?= =?us-ascii?q?kIOCI48GHPi8x/kqRboA66pxdix4LYeZyZOOZicq/Ye94RWGhPUdtLVyFZAo2y?= =?us-ascii?q?cZYBAOgPPehWrIfyqEcBoACiBQWwHu7j1iNEimPq0aA8zu8vERvG3AslH98WrH?= =?us-ascii?q?rUscj6NKYPWu601qnIzDPDYOhI1jfn54jDbxcsoeuRXb1tcMrd00YvFxnEjlWW?= =?us-ascii?q?soPqISmV1usWvmiU6upvT+Ovi2o9pw5tpTivw94hh4/UjYwbzVDE8D92wIczJd?= =?us-ascii?q?CgR057YMKkEJtNty6BLYd5XsQiQ2RutS0nybMGoYa2cDYWxJkj3RLSaPyKf5KV?= =?us-ascii?q?7h/nSuqdOyp0iXF5dL6niBu/9VKsxvPyW8WoylpGsDRJn9fWunwQ1RHf986KQe?= =?us-ascii?q?Zn8Ei7wzaAzQXT5/lEIU8qkarbLIYswrsqmZoStUTPBzf2mEvqgKOPeEUo5+ul?= =?us-ascii?q?5/j9brXpoZ+cMIB0igXgPag0hsO/BuE4PhAPX2id5+u8yKXu8VPlTLhOlPE7ka?= =?us-ascii?q?nUvIrHKckfuKK1GRJZ34U/5xqnCjepytUYnX0JLFJffxKHipDkO0vTIP/lDPez?= =?us-ascii?q?mVuskC1qx/DAJbLuHI/NLnfYnbfueLZy8U9cyA4pwd9D4JJUD6kNIOjvVU/pqN?= =?us-ascii?q?zYEhg5PhSozOn9DdV90poSWWaOAq+CLKPfqkSI5+IqI+mUfoAZojf9K/4/5/7v?= =?us-ascii?q?l3A1g1EdfbP6lacQPTqAF+lia2zfKUHwj9wCFWoQ9EJqV/Dng16qSiJebHWpWK?= =?us-ascii?q?wgoDo8DdTiRaDIT4WpyJmI3SO6GJIeQmFdFhjYGn7tc8CAWuwQQCOUOM5o1DIe?= =?us-ascii?q?A+uPUYgkgCuzuA6y5KBmKODZ4CJQ4Yj+2Nkz6PfSkxs/7zNcAMGU0mXLRGZxyD?= =?us-ascii?q?BbDwQq1bxy9BQugmyI1rJ11rkBTYQKtqF5FzwiPJuZ9NRUTtX7WwbPZNCMEQ/0?= =?us-ascii?q?TdCvADV3RdU0kYZXPxRNXu66hxWG5BKERqcPnuXSVpMx+6PYmXP2IpQlkiuU5O?= =?us-ascii?q?wal1AjB/B3Gyimi6p4rVaBAofIlwCBmf7ve/1MhGjC82CMyWfIt0ZdAlZ9?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BYCgAJ7fNahrTAVdFchFWBI5hhgXmBD?= =?us-ascii?q?4dijUALIwmEQAKCcRkHAQQ1EwECAQEBAQEBAQEBEwEBAQgLCwgoIwyCNSQBgk8?= =?us-ascii?q?BAgIBQAEbHgMBCwYFISUPARMRAQUBHAYBLYMIAoFmAQMNBwEPnns8jHsJBQEXg?= =?us-ascii?q?nAFg1EKGSYNVFeCQAIBBQkBCIgTgVQ/gQ+CXS6DEQKHNAKMdos2CIFlhAKQK4U?= =?us-ascii?q?giUmGXwIEAgQFAgUPIYEENIFyTSNQgkOCLoNOil5jdx4Njx0BAQ?= X-IPAS-Result: =?us-ascii?q?A0BYCgAJ7fNahrTAVdFchFWBI5hhgXmBD4dijUALIwmEQAK?= =?us-ascii?q?CcRkHAQQ1EwECAQEBAQEBAQEBEwEBAQgLCwgoIwyCNSQBgk8BAgIBQAEbHgMBC?= =?us-ascii?q?wYFISUPARMRAQUBHAYBLYMIAoFmAQMNBwEPnns8jHsJBQEXgnAFg1EKGSYNVFe?= =?us-ascii?q?CQAIBBQkBCIgTgVQ/gQ+CXS6DEQKHNAKMdos2CIFlhAKQK4UgiUmGXwIEAgQFA?= =?us-ascii?q?gUPIYEENIFyTSNQgkOCLoNOil5jdx4Njx0BAQ?= X-IronPort-AV: E=Sophos;i="5.49,384,1520895600"; d="scan'208";a="264810364" Received: from mail-pf0-f180.google.com ([209.85.192.180]) by mail3-smtp-sop.national.inria.fr with ESMTP/TLS/AES128-GCM-SHA256; 10 May 2018 09:00:19 +0200 Received: by mail-pf0-f180.google.com with SMTP id v63-v6so606290pfk.8 for ; Thu, 10 May 2018 00:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=qGM3XTO70FQ/Cd5YpeFNX0A7t6n7K7oqEzXIfPh4oYM=; b=JaEzr94Ab5fK6g82yMpEZjMqxp2zhkbP9Si2ANxz3FX6ZuZyDanvcXFdbrlskiHpYm hn1zVXsbM8eVg10aw7+SRlw7iCo1iobK1qekN7Ve5comRVL+GzI9PAH5rAEukOijcp7K y1wFWadpTVDeyFaJS+uFLDZLwo8P6UGTB0NYWfkWz/ZF8vlh5kXC1vRSU1lWQV+JKU46 XY5n5sZ+A0PZCHc6jT3dxJZcUMtsQzCTswV2UlXolN80w5GqaPyoFiOH4VfNTdQ5WoL7 1/BtNJuA+9TR+dg47D+M39US7wD1xs1+6s85i5ad2RZMBBD3ykAKbt5YllFZAIGCb1fu Xr5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=qGM3XTO70FQ/Cd5YpeFNX0A7t6n7K7oqEzXIfPh4oYM=; b=rlX/ppw58fK2ze/xYOqLQSKHcEySO2o7GOM/QNt5pDVjiOktNZxxwdl64zLp8P7OKI bSyhXbvK1MKYIWBtAfiuzsVVvJLmL9cAPjobzu1ru2BiG2Eu+FvRiTDjV8/9p5HHIKiq NTUAZGQLKsvDfnkubxwF7DB7QFypAoai99yGFFTHX5x5F3WIsvDumwyfgXSGWg+axPQ1 o6eRPjshEULjNZXPfjX/5hgQ09HaZgeGsBTrJih0SO6TM8yh/mmALN8kvgv1EKsMaGxh sLpaAOvb9Rk3S8fv3DhV/emg7tiA8P+wq5S+O3wjUeIHUA8nkToHTqep25vX0hoNtBMT G3wQ== X-Gm-Message-State: ALKqPwfh5NMU8T0JJeZ5uj2ND3WLmYSj0GY1rt3gWxB2Z0zWfEXf0Slk pgOSorT9HSLLmGwfJB8sHHqrTlOC X-Google-Smtp-Source: AB8JxZpVI5ISDGH2IPK5hXaTT2cItruYZSYSlpecUGSxBQ1vdBMoInzPfvwORMALRb4hfgZkIOT6nw== X-Received: by 2002:a63:6807:: with SMTP id d7-v6mr181600pgc.332.1525935617645; Thu, 10 May 2018 00:00:17 -0700 (PDT) Received: from localhost ([49.230.223.171]) by smtp.gmail.com with ESMTPSA id l90-v6sm574528pfb.149.2018.05.10.00.00.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 May 2018 00:00:15 -0700 (PDT) From: Rudi Grinberg To: "Paul A. Steckler" , Ocaml Mailing List In-Reply-To: References: Date: Thu, 10 May 2018 14:00:11 +0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Caml-list] Porting old-style ppx to driver-style? Reply-To: Rudi Grinberg X-Loop: caml-list@inria.fr X-Sequence: 16888 Errors-to: caml-list-owner@inria.fr Precedence: list Precedence: bulk Sender: caml-list-request@inria.fr X-no-archive: yes List-Id: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Paul, > I believe the solution is to turn the ppx into a new-style "driver". > What's the best way to do that? Is it as simple as changing the build > to use a jbuild as described in the section "Creating a new Ppx_driver > based rewriter"?: Using ppx_driver (now a part of ppxlib I believe) isn't necessary. I think it should be enough to follow the lead of other ppx_deriving plugins that are built with dune (ppx_deriving_yojson for example). The necessary bit here is to use omp and generate a correct META file that will make ppx_deriving_lens usable in driver *and* as a dynlinked deriver for ppx_deriving itself. There's an existing PR to port ocaml-lens and I believe it's on the right track: https://github.com/pdonadeo/ocaml-lens/pull/9 Perhaps you can help out with that effort? Cheers, Rudi. -- Caml-list mailing list. Subscription management and archives: https://sympa.inria.fr/sympa/arc/caml-list Beginner's list: http://groups.yahoo.com/group/ocaml_beginners Bug reports: http://caml.inria.fr/bin/caml-bugs