From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by sympa.inria.fr (Postfix) with ESMTPS id 3C9E97F860 for ; Thu, 6 Mar 2014 12:56:01 +0100 (CET) Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of sylvain@le-gall.net) identity=pra; client-ip=80.91.229.3; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="gclci-caml-list@m.gmane.org"; x-sender="sylvain@le-gall.net"; x-conformance=sidf_compatible Received-SPF: Pass (mail2-smtp-roc.national.inria.fr: domain of gclci-caml-list@m.gmane.org designates 80.91.229.3 as permitted sender) identity=mailfrom; client-ip=80.91.229.3; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="gclci-caml-list@m.gmane.org"; x-sender="gclci-caml-list@m.gmane.org"; x-conformance=sidf_compatible; x-record-type="v=spf1" Received-SPF: Pass (mail2-smtp-roc.national.inria.fr: domain of postmaster@plane.gmane.org designates 80.91.229.3 as permitted sender) identity=helo; client-ip=80.91.229.3; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="gclci-caml-list@m.gmane.org"; x-sender="postmaster@plane.gmane.org"; x-conformance=sidf_compatible; x-record-type="v=spf1" X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgEEAOFhGFNQW+UDh2dsb2JhbABag0GDXb8sFg4BAQEKCwkHFiiCJQEBAQQjDwFWCxgCAiYCAhAsGxmHfQEIrhOgfoEpjGEBAWyCWYFJBJlwiScEinuBcQ X-IPAS-Result: AgEEAOFhGFNQW+UDh2dsb2JhbABag0GDXb8sFg4BAQEKCwkHFiiCJQEBAQQjDwFWCxgCAiYCAhAsGxmHfQEIrhOgfoEpjGEBAWyCWYFJBJlwiScEinuBcQ X-IronPort-AV: E=Sophos;i="4.97,599,1389740400"; d="scan'208";a="61551910" Received: from plane.gmane.org ([80.91.229.3]) by mail2-smtp-roc.national.inria.fr with ESMTP/TLS/AES256-SHA; 06 Mar 2014 12:56:00 +0100 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WLWu7-0003kp-0b for caml-list@inria.fr; Thu, 06 Mar 2014 12:55:59 +0100 Received: from root.ovh.le-gall.net ([37.59.37.175]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 06 Mar 2014 12:55:59 +0100 Received: from sylvain by root.ovh.le-gall.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 06 Mar 2014 12:55:59 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: caml-list@inria.fr From: Sylvain Le Gall Date: Thu, 6 Mar 2014 11:55:35 +0000 (UTC) Message-ID: References: <000b01cf3885$6f1ef7a0$4d5ce6e0$@metastack.com> <3A42ACD2FA7345B29C464538724DECD5@erratique.ch> <20140305.211003.1668243541649395876.Christophe.Troestler@umons.ac.be> <554B600BA124496EA06BE4CD03D89A9A@erratique.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: root.ovh.le-gall.net User-Agent: slrn/pre1.0.0-18 (Linux) Subject: Re: [Caml-list] Project hosting for new OCaml projects On 06-03-2014, Daniel Bünzli wrote: > Le mercredi, 5 mars 2014 à 21:10, Christophe Troestler a écrit : >> On Wed, 5 Mar 2014 21:00:40 +0100, Daniel Bünzli wrote: >> > >> > [...] the pull request mechanism is broken (e.g. it completely >> > muddies history with useless commits) [...] >> >> P.S. You can always merge using the command line¹ which does not have >> that problem. >> >> ¹ The URL is provided in the mail Github send you so you do not even >> have to go to the Github site. > > Yes, that's what I do. But that's not the only thing that is broken about pull requests. > > I think the mechanism (each pull request is a branch on which you push > commits) makes it too easy to get non-logical, incoherent commits. > There's a pull request, you ask for corrections. The contributor > instead of correcting, amending its commit and force pushing to the > branch just adds commits to the branch, which results in a sequence of > commits that may not make much sense on your main branch (even worse > it may put your project in an intermediate bad state on certain > checkouts which is bad for git bisecting). Of course you can always > ask people to do the right thing, but I think the actual contribution > process should make you do the right thing. > > An example here (not to be mean to this fine individual trying to > contribute to the opam repository): > > https://github.com/ocaml/opam-repository/pull/1756 > > The second commit will make no sense in the history of the opam-repository. > I also find the UI and workflow for reviewing code not very good (better than nothing though) Have you tried Gerrit ? http://gerrithub.io/ N.B. you can also run gerrit on your server. If you have time to try it and you think it is a better alternative, just let us know. Cheers, Sylvain Le Gall -- Website: http://sylvain.le-gall.net/ OCaml forge: http://forge.ocamlcore.org OCaml blogs: http://planet.ocaml.org