From mboxrd@z Thu Jan  1 00:00:00 1970
From: andy at warmcat.com (Andy Green)
Date: Sun, 17 Jun 2018 10:28:13 +0800
Subject: [PATCH 2/2] gcc8.1: fix strcat warning
In-Reply-To: <20180616235210.3b75d3bf@leda>
References: <152884643982.29435.12041657288903581464.stgit@mail.warmcat.com>
 <152884644738.29435.16487549202475422342.stgit@mail.warmcat.com>
 <20180616131150.GP1922@john.keeping.me.uk> <20180616235210.3b75d3bf@leda>
Message-ID: <0c8e55e7-d7ea-22b2-6f5b-729ffdda2ed7@warmcat.com>



On 06/17/2018 05:52 AM, Christian Hesse wrote:
> John Keeping <john at keeping.me.uk> on Sat, 2018/06/16 14:11:
>> On Wed, Jun 13, 2018 at 07:34:07AM +0800, Andy Green wrote:
>>> ../ui-ssdiff.c: In function ?replace_tabs?:
>>> ../ui-ssdiff.c:142:4: warning: ?strncat? output truncated copying between
>>> 1 and 8 bytes from a string of length 8 [-Wstringop-truncation]
>>> strncat(result, spaces, 8 - (strlen(result) % 8));
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Actually the strncat that was there before intends that its
>>> stock of spaces gets truncated, and it's not a problem.
>>>
>>> However gcc8.1 is also right, normally truncation is undesirable.
>>>
>>> Make the code do the padding explicitly.
>>>
>>> Signed-off-by: Andy Green <andy at warmcat.com>
>>
>> Reviewed-by: John Keeping <john at keeping.me.uk>
> 
> Agreed, except the typo in commit message. This is about strncat, not strcat.
> 

OK... I fixed that and dropped the first patch.