[RESEND] [PATCH v2 1/1] commit-links.sh: improve regular expressions

[RESEND] [PATCH v2 1/1] commit-links.sh: improve regular expressions

[mailings]

From: Ferry Huberts <ferry.huberts at pelagic.nl>

Signed-off-by: Ferry Huberts <ferry.huberts at pelagic.nl>
---
 filters/commit-links.sh |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/filters/commit-links.sh b/filters/commit-links.sh
index d2cd2b3..5881952 100755
--- a/filters/commit-links.sh
+++ b/filters/commit-links.sh
@@ -15,11 +15,14 @@
 # CGIT_REPO_CLONE_URL  ( = repo.clone-url setting )
 #
 
+regex=''
+
 # This expression generates links to commits referenced by their SHA1.
 regex=$regex'
-s|\b([0-9a-fA-F]{8,40})\b|<a href="./?id=\1">\1</a>|g'
+s|\b([0-9a-fA-F]{7,40})\b|<a href="./?id=\1">\1</a>|g'
+
 # This expression generates links to a fictional bugtracker.
 regex=$regex'
-s| #([0-9]+)\b|<a href="http://bugs.example.com/?bug=\1">#\1</a>|g'
+s|#([0-9]+)\b|<a href="http://bugs.example.com/?bug=\1">#\1</a>|g'
 
 sed -re "$regex"
-- 
1.7.5.4

[RESEND] [PATCH v2 1/1] commit-links.sh: improve regular expressions

[hjemli]

On Wed, Jun 22, 2011 at 22:46, Ferry Huberts <mailings at hupie.com> wrote:
> From: Ferry Huberts <ferry.huberts at pelagic.nl>
>
> Signed-off-by: Ferry Huberts <ferry.huberts at pelagic.nl>

I still would like a commit message for this patch which describes the
rationale for the changes it introduces, i.e. what's wrong with the
first usage of $regex, why is 7 a better number than 8, and why
shouldn't the ticket hash be prefixed by a space? And are there any
other changes in the patch which I didn't spot?

--
larsh

[RESEND] [PATCH v2 1/1] commit-links.sh: improve regular expressions

[hjemli]

On Wed, Jun 22, 2011 at 23:12, Ferry Huberts <mailings at hupie.com> wrote:
> On 06/22/2011 11:09 PM, Lars Hjemli wrote:
>> I still would like a commit message for this patch which describes the
>> rationale for the changes it introduces
>
> [snip]
>
> or do you want a new patch?

Yes. I do agree that all three changes are improvements, but it would
be nice to get an explanation of the improvements in the commit
message.

-- 
larsh

[PATCH v3 1/1] commit-links.sh: improve regular expressions

[mailings]

From: Ferry Huberts <ferry.huberts at pelagic.nl>

The default length for sha1 abbreviations in git is 7.

A '#num' at the beginning of the commit message is now
recognised, a ':#num' as well, etc.: a '#num' anywhere
is now converted to a link.

Signed-off-by: Ferry Huberts <ferry.huberts at pelagic.nl>
---
 filters/commit-links.sh |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/filters/commit-links.sh b/filters/commit-links.sh
index d2cd2b3..5881952 100755
--- a/filters/commit-links.sh
+++ b/filters/commit-links.sh
@@ -15,11 +15,14 @@
 # CGIT_REPO_CLONE_URL  ( = repo.clone-url setting )
 #
 
+regex=''
+
 # This expression generates links to commits referenced by their SHA1.
 regex=$regex'
-s|\b([0-9a-fA-F]{8,40})\b|<a href="./?id=\1">\1</a>|g'
+s|\b([0-9a-fA-F]{7,40})\b|<a href="./?id=\1">\1</a>|g'
+
 # This expression generates links to a fictional bugtracker.
 regex=$regex'
-s| #([0-9]+)\b|<a href="http://bugs.example.com/?bug=\1">#\1</a>|g'
+s|#([0-9]+)\b|<a href="http://bugs.example.com/?bug=\1">#\1</a>|g'
 
 sed -re "$regex"
-- 
1.7.5.4

[RESEND] [PATCH v3 1/1] commit-links.sh: improve regular expressions

[mailings]

From: Ferry Huberts <ferry.huberts at pelagic.nl>

The default length for sha1 abbreviations in git is 7.

A '#num' at the beginning of the commit message is now
recognised, a ':#num' as well, etc.: a '#num' anywhere
is now converted to a link.

Signed-off-by: Ferry Huberts <ferry.huberts at pelagic.nl>
---
 filters/commit-links.sh |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/filters/commit-links.sh b/filters/commit-links.sh
index d2cd2b3..5881952 100755
--- a/filters/commit-links.sh
+++ b/filters/commit-links.sh
@@ -15,11 +15,14 @@
 # CGIT_REPO_CLONE_URL  ( = repo.clone-url setting )
 #
 
+regex=''
+
 # This expression generates links to commits referenced by their SHA1.
 regex=$regex'
-s|\b([0-9a-fA-F]{8,40})\b|<a href="./?id=\1">\1</a>|g'
+s|\b([0-9a-fA-F]{7,40})\b|<a href="./?id=\1">\1</a>|g'
+
 # This expression generates links to a fictional bugtracker.
 regex=$regex'
-s| #([0-9]+)\b|<a href="http://bugs.example.com/?bug=\1">#\1</a>|g'
+s|#([0-9]+)\b|<a href="http://bugs.example.com/?bug=\1">#\1</a>|g'
 
 sed -re "$regex"
-- 
1.7.5.4

[RESEND] [PATCH v3 1/1] commit-links.sh: improve regular expressions

[larsh]

On Mon, Jul 18, 2011 at 12:45:20PM +0200, Ferry Huberts wrote:
>  filters/commit-links.sh |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)

Thanks, and sorry for the late response (it's holiday season). I've
applied this patch to my master branch.

--
larsh