From: jamie.couture at gmail.com (Jamie Couture)
Subject: [PATCH 2/2] use correct type for sizeof
Date: Wed, 11 Jan 2012 22:38:49 -0500 [thread overview]
Message-ID: <1326339529-1180-3-git-send-email-jamie.couture@gmail.com> (raw)
In-Reply-To: <1326339529-1180-1-git-send-email-jamie.couture@gmail.com>
**L would have worked well too. Depending on the distribution sizeof *L
may return 8 instead of 4. **L is preferable, but since we don't expect
this datatype to change very often, sizeof int is less subtle and easier
to understand.
Signed-off-by: Jamie Couture <jamie.couture at gmail.com>
---
ui-ssdiff.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index 45770b1..0cff4b8 100644
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -23,7 +23,7 @@ static void create_or_reset_lcs_table()
int i;
if (L != NULL) {
- memset(*L, 0, sizeof(*L) * MAX_SSDIFF_SIZE);
+ memset(*L, 0, sizeof(int) * MAX_SSDIFF_SIZE);
return;
}
--
1.7.7.4
next prev parent reply other threads:[~2012-01-12 3:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 4:43 [PATCH 0/1] segfault in cgit jamie.couture
2011-09-09 4:43 ` [PATCH 1/1] move LCS table away from the stack jamie.couture
2011-09-11 0:44 ` jamie.couture
2011-09-11 0:44 ` [PATCH] " jamie.couture
2011-09-14 6:38 ` hjemli
2011-09-17 22:25 ` [PATCH 1/1] " jamie.couture
2012-01-03 15:12 ` hjemli
2012-01-04 8:59 ` normalperson
2012-01-04 16:57 ` jamie.couture
2012-01-12 3:38 ` jamie.couture
2012-01-12 3:38 ` [PATCH 1/2] correct length check for LCS table jamie.couture
2012-01-12 3:38 ` jamie.couture [this message]
2012-03-18 9:22 ` [PATCH 2/2] use correct type for sizeof hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326339529-1180-3-git-send-email-jamie.couture@gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).