List for cgit developers and users
 help / color / mirror / Atom feed
From: mailings at hupie.com (Ferry Huberts)
Subject: [PATCH 2/2] tests: properly quote more variables
Date: Thu, 19 Jan 2012 20:24:15 +0100	[thread overview]
Message-ID: <1327001055-29027-2-git-send-email-mailings@hupie.com> (raw)
In-Reply-To: <1327001055-29027-1-git-send-email-mailings@hupie.com>

From: Ferry Huberts <ferry.huberts at pelagic.nl>

Signed-off-by: Ferry Huberts <ferry.huberts at pelagic.nl>
---
 tests/setup.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/setup.sh b/tests/setup.sh
index 3b52de9..c54609c 100755
--- a/tests/setup.sh
+++ b/tests/setup.sh
@@ -18,11 +18,11 @@
 unset CDPATH
 
 mkrepo() {
-	name=$1
+	name="$1"
 	count=$2
 	dir="$PWD"
 	test -d "$name" && return
-	printf "Creating testrepo %s\n" $name
+	printf "Creating testrepo %s\n" "$name"
 	mkdir -p "$name"
 	cd "$name"
 	git init
@@ -114,8 +114,8 @@ run_test()
 		bug=1
 		shift
 	fi
-	desc=$1
-	script=$2
+	desc="$1"
+	script="$2"
 	test_count=$(expr $test_count + 1)
 	printf "\ntest %d: name='%s'\n" $test_count "$desc" >>test-output.log
 	printf "test %d: eval='%s'\n" $test_count "$2" >>test-output.log
-- 
1.7.7.5





  reply	other threads:[~2012-01-19 19:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 19:24 [PATCH 1/2] tests: handle paths with whitespace mailings
2012-01-19 19:24 ` mailings [this message]
2012-01-19 20:57   ` [PATCH 2/2] tests: properly quote more variables cgit
2012-01-19 21:08     ` mailings
2012-01-21 20:39       ` cgit
2012-01-19 20:54 ` [PATCH 1/2] tests: handle paths with whitespace cgit
2012-01-29 15:29 ` [PATCH v2 " mailings
2012-01-29 15:29   ` [PATCH v2 2/2] tests: properly quote arguments to printf mailings
2012-03-06 22:26 ` [PATCH v2 1/2] tests: handle paths with whitespace mailings
2012-03-06 22:26   ` [PATCH v2 2/2] tests: properly quote arguments to printf mailings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327001055-29027-2-git-send-email-mailings@hupie.com \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).