From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH 6/7] ui-tree.c: Drop the header variable
Date: Sun, 3 Mar 2013 18:06:46 +0100 [thread overview]
Message-ID: <1362330407-16034-7-git-send-email-cgit@cryptocrack.de> (raw)
In-Reply-To: <1362330407-16034-1-git-send-email-cgit@cryptocrack.de>
Instead, use the value of the state variable to determine whether the
footer needs to be drawn.
Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
---
ui-tree.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/ui-tree.c b/ui-tree.c
index 3887ecd..744e039 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -13,7 +13,6 @@
char *curr_rev;
char *match_path;
-int header = 0;
static int state;
static void print_text_buffer(const char *name, char *buf, unsigned long size)
@@ -189,15 +188,11 @@ static void ls_head()
html("<th class='right'>Size</th>");
html("<th/>");
html("</tr>\n");
- header = 1;
}
static void ls_tail()
{
- if (!header)
- return;
html("</table>\n");
- header = 0;
}
static void ls_tree(const unsigned char *sha1, char *path)
@@ -276,5 +271,6 @@ void cgit_print_tree(const char *rev, char *path)
match_path = path;
state = 0;
read_tree_recursive(commit->tree, "", 0, 0, paths, walk_tree, NULL);
- ls_tail();
+ if (state == 1)
+ ls_tail();
}
--
1.8.2.rc0.247.g811e0c0
next prev parent reply other threads:[~2013-03-03 17:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-03 17:06 [PATCH 0/7] Use context structures in walk_tree() functions cgit
2013-03-03 17:06 ` [PATCH 1/7] ui-blob.c: Use a context structure in walk_tree() cgit
2013-03-03 19:56 ` mailings
2013-03-03 20:25 ` john
2013-03-03 20:33 ` mailings
2013-03-03 20:39 ` cgit
2013-03-03 20:41 ` john
2013-03-03 21:21 ` mailings
2013-03-03 23:49 ` Jason
2013-03-03 17:06 ` [PATCH 2/7] ui-plain.c: Do not access match variable in print_*() cgit
2013-03-03 17:06 ` [PATCH 3/7] ui-plain.c: Use a context structure in walk_tree() cgit
2013-03-03 20:04 ` mailings
2013-03-03 21:02 ` cgit
2013-03-03 21:12 ` [PATCH v2] " cgit
2013-03-03 17:06 ` [PATCH 4/7] ui-tree.c: Pass current revision to print_object() cgit
2013-03-03 17:06 ` [PATCH 5/7] ui-tree.c: Declare the state variable globally cgit
2013-03-03 20:08 ` mailings
2013-03-03 20:28 ` john
2013-03-03 20:42 ` cgit
2013-03-03 23:47 ` Jason
2013-03-03 23:54 ` cgit
2013-03-03 17:06 ` cgit [this message]
2013-03-03 17:06 ` [PATCH 7/7] ui-tree.c: Use a context structure in walk_tree() cgit
2013-03-03 20:13 ` mailings
2013-03-03 20:43 ` cgit
2013-03-03 21:23 ` [PATCH 0/7] Use context structures in walk_tree() functions mailings
2013-03-04 5:06 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362330407-16034-7-git-send-email-cgit@cryptocrack.de \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).