From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH] html.c: Replace strdup() with xstrdup()
Date: Sat, 6 Apr 2013 11:11:23 +0200 [thread overview]
Message-ID: <1365239483-14912-1-git-send-email-cgit@cryptocrack.de> (raw)
Use the xstrdup() wrapper which already bails out if strdup() returns a
NULL pointer.
Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
---
`grep '[^x]strdup' *.c` tells me that this is the only place where we
still use strdup() instead of xstrdup().
html.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/html.c b/html.c
index d60a41f..88f3e67 100644
--- a/html.c
+++ b/html.c
@@ -306,11 +306,7 @@ int http_parse_querystring(const char *txt_, void (*fn)(const char *name, const
if (!txt_)
return 0;
- o = t = txt = strdup(txt_);
- if (t == NULL) {
- printf("Out of memory\n");
- exit(1);
- }
+ o = t = txt = xstrdup(txt_);
while ((c=*t) != '\0') {
if (c == '=') {
*t = '\0';
--
1.8.2.674.g2c8b7bf
next reply other threads:[~2013-04-06 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 9:11 cgit [this message]
2013-04-06 9:17 ` [PATCH v2] " cgit
2013-04-06 9:44 ` john
2013-04-06 10:50 ` cgit
2013-04-06 11:14 ` john
2013-04-06 11:30 ` [PATCH v3] " cgit
2013-04-06 14:26 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365239483-14912-1-git-send-email-cgit@cryptocrack.de \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).