From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH 1/2] ui-refs.c: Remove global header variable
Date: Sat, 6 Apr 2013 23:39:07 +0200 [thread overview]
Message-ID: <1365284348-24256-1-git-send-email-cgit@cryptocrack.de> (raw)
print_tag_header() is only called from cgit_print_tags() -- the
conditional invocation in print_tag() is never executed since
print_tag() is only called by cgit_print_tags() which already executes
print_tag_header() before (resulting in the global variable being always
set in when the condition is evaluated).
Remove the global variable and the conditional invocation.
Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
---
ui-refs.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/ui-refs.c b/ui-refs.c
index 5bebed1..0399e6b 100644
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -11,8 +11,6 @@
#include "html.h"
#include "ui-shared.h"
-static int header;
-
static int cmp_age(int age1, int age2)
{
if (age1 != 0 && age2 != 0)
@@ -96,7 +94,6 @@ static void print_tag_header()
"<th class='left'>Download</th>"
"<th class='left'>Author</th>"
"<th class='left' colspan='2'>Age</th></tr>\n");
- header = 1;
}
static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
@@ -156,8 +153,6 @@ static int print_tag(struct refinfo *ref)
cgit_print_age(info->tagger_date, -1, NULL);
html("</td></tr>\n");
} else {
- if (!header)
- print_tag_header();
html("<tr><td>");
cgit_tag_link(name, NULL, NULL, ctx.qry.head, name);
html("</td><td>");
@@ -221,7 +216,6 @@ void cgit_print_tags(int maxcount)
struct reflist list;
int i;
- header = 0;
list.refs = NULL;
list.alloc = list.count = 0;
for_each_tag_ref(cgit_refs_cb, &list);
--
1.8.2.674.g2c8b7bf
next reply other threads:[~2013-04-06 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 21:39 cgit [this message]
2013-04-06 21:39 ` [PATCH 2/2] ui-refs.c: Refactor print_tag() cgit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365284348-24256-1-git-send-email-cgit@cryptocrack.de \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).