List for cgit developers and users
 help / color / mirror / Atom feed
From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH v2 2/2] t0107: Skip ZIP tests if unzip(1) isn't available
Date: Tue,  9 Apr 2013 20:02:33 +0200	[thread overview]
Message-ID: <1365530553-15381-2-git-send-email-cgit@cryptocrack.de> (raw)
In-Reply-To: <1365530553-15381-1-git-send-email-cgit@cryptocrack.de>

Note that we cannot use skip_all here since some tests have already been
executed when ZIP tests are reached. Use test prerequisites to skip
everything using unzip(1) if the binary is not available instead.

Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
---
Rebased on current master.

 tests/t0107-snapshot.sh | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/tests/t0107-snapshot.sh b/tests/t0107-snapshot.sh
index 7e6f5bf..053062c 100755
--- a/tests/t0107-snapshot.sh
+++ b/tests/t0107-snapshot.sh
@@ -54,21 +54,27 @@ test_expect_success 'strip off the header lines (zip)' '
 	tail -n +6 tmp >master.zip
 '
 
-test_expect_success 'verify zip format' '
+if test -n "$(which unzip 2>/dev/null)"; then
+	test_set_prereq UNZIP
+else
+	say 'Skipping ZIP validation tests: unzip not found'
+fi
+
+test_expect_success UNZIP 'verify zip format' '
 	unzip -t master.zip
 '
 
-test_expect_success 'unzip' '
+test_expect_success UNZIP 'unzip' '
 	rm -rf master &&
 	unzip master.zip
 '
 
-test_expect_success 'count files (zip)' '
+test_expect_success UNZIP 'count files (zip)' '
 	ls master/ >output &&
 	test_line_count = 5 output
 '
 
-test_expect_success 'verify unzipped file-5' '
+test_expect_success UNZIP 'verify unzipped file-5' '
 	grep "^5$" master/file-5 &&
 	test_line_count = 1 master/file-5
 '
-- 
1.8.2.675.gda3bb24.dirty





  reply	other threads:[~2013-04-09 18:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 18:02 [PATCH v2 1/2] tests/: Do not use `sed -i` cgit
2013-04-09 18:02 ` cgit [this message]
2013-04-09 18:13   ` [PATCH v2 2/2] t0107: Skip ZIP tests if unzip(1) isn't available Jason
2013-04-09 18:13 ` [PATCH v2 1/2] tests/: Do not use `sed -i` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365530553-15381-2-git-send-email-cgit@cryptocrack.de \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).