From mboxrd@z Thu Jan 1 00:00:00 1970
From: lekensteyn at gmail.com (Peter Wu)
Date: Thu, 3 Oct 2013 12:17:23 +0200
Subject: [PATCH] Reduce line number bloat, fix hover effect
Message-ID: <1380795443-3803-1-git-send-email-lekensteyn@gmail.com>
Currently line numbers look like (for blob view and sdiff respectively):
68
---
cgit.css | 6 ++++--
ui-ssdiff.c | 8 ++++----
ui-tree.c | 2 +-
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/cgit.css b/cgit.css
index d467c66..71b0b9b 100644
--- a/cgit.css
+++ b/cgit.css
@@ -291,13 +291,15 @@ div#cgit table.blob pre {
padding: 0; margin: 0;
}
-div#cgit table.blob a.no, div#cgit table.ssdiff a.no {
+div#cgit table.blob td.linenumbers a,
+div#cgit table.ssdiff td.lineno a {
color: gray;
text-align: right;
text-decoration: none;
}
-div#cgit table.blob a.no a:hover {
+div#cgit table.blob td.linenumbers a:hover,
+div#cgit table.ssdiff td.lineno a:hover {
color: black;
}
diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index cbe60bd..08cf513 100644
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -230,9 +230,9 @@ static void print_ssdiff_line(char *class,
struct diff_filespec *old_file = cgit_get_current_old_file();
char *lineno_str = fmt("n%d", old_line_no);
char *id_str = fmt("id=%s#%s", is_null_sha1(old_file->sha1)?"HEAD":sha1_to_hex(old_rev_sha1), lineno_str);
- html("%s", lineno_str, lineno_str, lineno_str + 1);
+ htmlf("' id='%s'>%s", lineno_str, lineno_str + 1);
html(" | ");
htmlf("", class);
} else if (old_line)
@@ -251,9 +251,9 @@ static void print_ssdiff_line(char *class,
struct diff_filespec *new_file = cgit_get_current_new_file();
char *lineno_str = fmt("n%d", new_line_no);
char *id_str = fmt("id=%s#%s", is_null_sha1(new_file->sha1)?"HEAD":sha1_to_hex(new_rev_sha1), lineno_str);
- html(" | %s", lineno_str, lineno_str, lineno_str + 1);
+ htmlf("' id='%s'>%s", lineno_str, lineno_str + 1);
html(" | ");
htmlf("", class);
} else if (new_line)
diff --git a/ui-tree.c b/ui-tree.c
index aa5dee9..9fb9590 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -22,7 +22,7 @@ static void print_text_buffer(const char *name, char *buf, unsigned long size)
{
unsigned long lineno, idx;
const char *numberfmt =
- "%1$d\n";
+ "%1$d\n";
html(" |