From mboxrd@z Thu Jan 1 00:00:00 1970 From: cgit at cryptocrack.de (Lukas Fleischer) Date: Fri, 10 Jan 2014 12:44:36 +0100 Subject: [PATCH 2/4] Disallow use of undocumented snapshot delimiters In-Reply-To: <1389354278-9561-1-git-send-email-cgit@cryptocrack.de> References: <1389354278-9561-1-git-send-email-cgit@cryptocrack.de> Message-ID: <1389354278-9561-2-git-send-email-cgit@cryptocrack.de> Since the introduction of selective snapshot format configuration in dc3c9b5 (allow selective enabling of snapshots, 2007-07-21), we allowed seven different delimiters for snapshot formats, while the documentation has always been clear about spaces being the only valid delimiter: The value is a space-separated list of zero or more of the values "tar", "tar.gz", "tar.bz2", "tar.xz" and "zip". Supporting the undocumented delimiters makes the code unnecessarily complex. Remove them. Signed-off-by: Lukas Fleischer --- shared.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shared.c b/shared.c index c5c4b00..1f6310a 100644 --- a/shared.c +++ b/shared.c @@ -405,7 +405,7 @@ void cgit_diff_commit(struct commit *commit, filepair_fn fn, const char *prefix) int cgit_parse_snapshots_mask(const char *str) { const struct cgit_snapshot_format *f; - static const char *delim = " \t,:/|;"; + static const char *delim = " "; int tl, sl, rv = 0; /* favor legacy setting */ -- 1.8.5.2