From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH 4/4] ui-snapshot.c: Do not reinvent suffixcmp()
Date: Fri, 10 Jan 2014 12:44:38 +0100 [thread overview]
Message-ID: <1389354278-9561-4-git-send-email-cgit@cryptocrack.de> (raw)
In-Reply-To: <1389354278-9561-1-git-send-email-cgit@cryptocrack.de>
Use suffixcmp() from Git instead of reimplementing it. This is a
preparation for moving to ends_with() in Git 1.8.6.
Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
---
ui-snapshot.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/ui-snapshot.c b/ui-snapshot.c
index 901c0c9..8f82119 100644
--- a/ui-snapshot.c
+++ b/ui-snapshot.c
@@ -98,14 +98,9 @@ const struct cgit_snapshot_format cgit_snapshot_formats[] = {
static const struct cgit_snapshot_format *get_format(const char *filename)
{
const struct cgit_snapshot_format *fmt;
- int fl, sl;
- fl = strlen(filename);
for (fmt = cgit_snapshot_formats; fmt->suffix; fmt++) {
- sl = strlen(fmt->suffix);
- if (sl >= fl)
- continue;
- if (!strcmp(fmt->suffix, filename + fl - sl))
+ if (!suffixcmp(filename, fmt->suffix))
return fmt;
}
return NULL;
--
1.8.5.2
next prev parent reply other threads:[~2014-01-10 11:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 11:44 [PATCH 1/4] Replace most uses of strncmp() with prefixcmp() cgit
2014-01-10 11:44 ` [PATCH 2/4] Disallow use of undocumented snapshot delimiters cgit
2014-01-10 16:04 ` Jason
2014-01-10 11:44 ` [PATCH 3/4] Refactor cgit_parse_snapshots_mask() cgit
2014-01-10 16:04 ` Jason
2014-01-10 11:44 ` cgit [this message]
2014-01-10 16:05 ` [PATCH 4/4] ui-snapshot.c: Do not reinvent suffixcmp() Jason
2014-01-10 16:02 ` [PATCH 1/4] Replace most uses of strncmp() with prefixcmp() Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389354278-9561-4-git-send-email-cgit@cryptocrack.de \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).