List for cgit developers and users
 help / color / mirror / Atom feed
From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH v2 1/3] t0111: Prepare for other filter prefixes
Date: Tue, 14 Jan 2014 22:25:45 +0100	[thread overview]
Message-ID: <1389734747-7135-1-git-send-email-cgit@cryptocrack.de> (raw)

* Validate the email filter by manipulating stdin. Additional checks for
  all the arguments can be added in a later patch.

* Add the exec prefix to all informational messages.

* Rename the filter repository to filter-exec. The Git repository itself
  is not renamed since it can be shared amongst all filter types.

Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
---
 tests/filters/capitalize-argv1.sh |  3 ---
 tests/setup.sh                    |  4 ++--
 tests/t0111-filter.sh             | 26 +++++++++++++-------------
 3 files changed, 15 insertions(+), 18 deletions(-)
 delete mode 100755 tests/filters/capitalize-argv1.sh

diff --git a/tests/filters/capitalize-argv1.sh b/tests/filters/capitalize-argv1.sh
deleted file mode 100755
index 2ea0098..0000000
--- a/tests/filters/capitalize-argv1.sh
+++ /dev/null
@@ -1,3 +0,0 @@
-#!/bin/sh
-
-echo "$1" | tr '[:lower:]' '[:upper:]'
diff --git a/tests/setup.sh b/tests/setup.sh
index 861f48a..a0a9be2 100755
--- a/tests/setup.sh
+++ b/tests/setup.sh
@@ -125,12 +125,12 @@ repo.url=with space
 repo.path=$PWD/repos/with space/.git
 repo.desc=spaced repo
 
-repo.url=filter
+repo.url=filter-exec
 repo.path=$PWD/repos/filter/.git
 repo.desc=filtered repo
 repo.about-filter=exec:$FILTER_DIRECTORY/capitalize-stdin.sh
 repo.commit-filter=exec:$FILTER_DIRECTORY/capitalize-stdin.sh
-repo.email-filter=exec:$FILTER_DIRECTORY/capitalize-argv1.sh
+repo.email-filter=exec:$FILTER_DIRECTORY/capitalize-stdin.sh
 repo.source-filter=exec:$FILTER_DIRECTORY/capitalize-stdin.sh
 repo.readme=master:a+b
 EOF
diff --git a/tests/t0111-filter.sh b/tests/t0111-filter.sh
index 2f99880..c235652 100755
--- a/tests/t0111-filter.sh
+++ b/tests/t0111-filter.sh
@@ -3,36 +3,36 @@
 test_description='Check filtered content'
 . ./setup.sh
 
-test_expect_success 'generate filter/tree/a%2bb' '
-	cgit_url "filter/tree/a%2bb" >tmp
+test_expect_success 'generate filter-exec/tree/a%2bb' '
+	cgit_url "filter-exec/tree/a%2bb" >tmp
 '
 
-test_expect_success 'check whether the source filter works' '
+test_expect_success 'check whether the exec source filter works' '
 	grep "<code>HELLO$" tmp
 '
 
-test_expect_success 'generate filter/about/' '
-	cgit_url "filter/about/" >tmp
+test_expect_success 'generate filter-exec/about/' '
+	cgit_url "filter-exec/about/" >tmp
 '
 
-test_expect_success 'check whether the about filter works' '
+test_expect_success 'check whether the exec about filter works' '
 	grep "<div id='"'"'summary'"'"'>HELLO$" tmp
 '
 
-test_expect_success 'generate filter/commit/' '
-	cgit_url "filter/commit/" >tmp
+test_expect_success 'generate filter-exec/commit/' '
+	cgit_url "filter-exec/commit/" >tmp
 '
 
-test_expect_success 'check whether the commit filter works' '
+test_expect_success 'check whether the exec commit filter works' '
 	grep "<div class='"'"'commit-subject'"'"'>ADD A+B" tmp
 '
 
-test_expect_success 'check whether the email filter works for authors' '
-	grep "<AUTHOR at EXAMPLE.COM>" tmp
+test_expect_success 'check whether the exec email filter works for authors' '
+	grep "A U THOR &LT;AUTHOR at EXAMPLE.COM&GT;" tmp
 '
 
-test_expect_success 'check whether the email filter works for committers' '
-	grep "<COMMITTER at EXAMPLE.COM>" tmp
+test_expect_success 'check whether the exec email filter works for committers' '
+	grep "C O MITTER &LT;COMMITTER at EXAMPLE.COM&GT;" tmp
 '
 
 test_done
-- 
1.8.5.2



             reply	other threads:[~2014-01-14 21:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 21:25 cgit [this message]
2014-01-14 21:25 ` [PATCH v2 2/3] t0111: Add basic tests for Lua filters cgit
2014-01-14 21:25 ` [PATCH 3/3] t0111: Check all arguments cgit
2014-01-15 13:46   ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389734747-7135-1-git-send-email-cgit@cryptocrack.de \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).