List for cgit developers and users
 help / color / mirror / Atom feed
From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH 0/4] Remove references to the global context variable
Date: Wed, 15 Jan 2014 22:37:03 +0100	[thread overview]
Message-ID: <1389821827-3483-1-git-send-email-cgit@cryptocrack.de> (raw)

Jason noticed that sometimes, we pass a reference (pointer) to the
global context variable. This series removes all such references and
replaces them with direct use of the global variable.

Most of the patches are much easier to review with the following
options:

    --word-diff=color --word-diff-regex='[a-zA-Z_]+|->|\.'

Comments welcome!

Lukas Fleischer (4):
  Remove context parameter from cgit_print_*()
  Remove context parameter from all commands
  cgit.c: Remove context parameter from initializations
  Remove callback data parameter for cache slots

 cache.c       |  14 ++-
 cache.h       |   5 +-
 cgit.c        | 249 ++++++++++++++++++++++++------------------------
 cmd.c         | 102 ++++++++++----------
 cmd.h         |   4 +-
 ui-atom.c     |   2 +-
 ui-blob.c     |   2 +-
 ui-clone.c    |  48 +++++-----
 ui-clone.h    |   6 +-
 ui-diff.c     |   2 +-
 ui-patch.c    |   2 +-
 ui-plain.c    |  14 +--
 ui-plain.h    |   2 +-
 ui-repolist.c |   6 +-
 ui-shared.c   | 297 +++++++++++++++++++++++++++++-----------------------------
 ui-shared.h   |   6 +-
 ui-snapshot.c |   8 +-
 ui-stats.c    |  29 +++---
 ui-stats.h    |   2 +-
 19 files changed, 397 insertions(+), 403 deletions(-)

-- 
1.8.5.2



             reply	other threads:[~2014-01-15 21:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 21:37 cgit [this message]
2014-01-15 21:37 ` [PATCH 1/4] Remove context parameter from cgit_print_*() cgit
2014-01-15 21:37 ` [PATCH 2/4] Remove context parameter from all commands cgit
2014-01-15 21:37 ` [PATCH 3/4] cgit.c: Remove context parameter from initializations cgit
2014-01-15 21:37 ` [PATCH 4/4] Remove callback data parameter for cache slots cgit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389821827-3483-1-git-send-email-cgit@cryptocrack.de \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).