From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH 1/2] parsing.c: Remove leading space from committer
Date: Wed, 15 Jan 2014 23:18:47 +0100 [thread overview]
Message-ID: <1389824328-4148-1-git-send-email-cgit@cryptocrack.de> (raw)
This did not really break anything in the past since spaces are ignored
when rendering HTML. Remove the preceding space anyway to prevent from
potential future problems.
Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
---
This would get fixed anyway when switching to strip_prefix(). However,
it is better to do this now to avoid any problems. It is also "required"
for the following patch (otherwise, we would have to add a workaround
for this bug to the test case which doesn't seem right and might lead to
confusion when the bug suddenly disappears after the strip_prefix()
migrate and the tests break).
parsing.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/parsing.c b/parsing.c
index 0062550..599f61e 100644
--- a/parsing.c
+++ b/parsing.c
@@ -156,7 +156,7 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
}
if (p && !prefixcmp(p, "committer ")) {
- p = parse_user(p + 9, &ret->committer, &ret->committer_email,
+ p = parse_user(p + 10, &ret->committer, &ret->committer_email,
&ret->committer_date);
}
--
1.8.5.2
next reply other threads:[~2014-01-15 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 22:18 cgit [this message]
2014-01-15 22:18 ` [PATCH 2/2] t0111: Additions and fixes cgit
2014-01-15 23:57 ` Jason
2014-01-15 23:57 ` [PATCH 1/2] parsing.c: Remove leading space from committer Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389824328-4148-1-git-send-email-cgit@cryptocrack.de \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).