[PATCH] footer: link back to cgit home page

[PATCH] footer: link back to cgit home page

[Jason]

The footer has always been overrideable using the footer= in cgitrc, so
this won't anger anybody who cares about their footer.
---
Is this horrible? Or is this acceptable?

 cgit.css    | 7 +++++++
 ui-shared.c | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/cgit.css b/cgit.css
index 71b0b9b..6888cde 100644
--- a/cgit.css
+++ b/cgit.css
@@ -590,6 +590,13 @@ div#cgit div.footer {
 	font-size: 80%;
 	color: #ccc;
 }
+div#cgit div.footer a {
+	color: #ccc;
+	text-decoration: none;
+}
+div#cgit div.footer a:hover {
+	text-decoration: underline;
+}
 div#cgit a.branch-deco {
 	color: #000;
 	margin: 0px 0.5em;
diff --git a/ui-shared.c b/ui-shared.c
index 1ede2b0..ba173f4 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -719,7 +719,7 @@ void cgit_print_docend()
 	if (ctx.cfg.footer)
 		html_include(ctx.cfg.footer);
 	else {
-		htmlf("<div class='footer'>generated  by cgit %s at ",
+		htmlf("<div class='footer'>generated by <a href='http://git.zx2c4.com/cgit/about/'>cgit %s</a> at ",
 			cgit_version);
 		cgit_print_date(time(NULL), FMT_LONGDATE, ctx.cfg.local_time);
 		html("</div>\n");
-- 
1.9.0

[PATCH] footer: link back to cgit home page

[stefan]

I personally think it's ok.

On March 19, 2014 10:14:17 AM CET, "Jason A. Donenfeld" <Jason at zx2c4.com> wrote:
>The footer has always been overrideable using the footer= in cgitrc, so
>this won't anger anybody who cares about their footer.
>---
>Is this horrible? Or is this acceptable?
>
> cgit.css    | 7 +++++++
> ui-shared.c | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/cgit.css b/cgit.css
>index 71b0b9b..6888cde 100644
>--- a/cgit.css
>+++ b/cgit.css
>@@ -590,6 +590,13 @@ div#cgit div.footer {
> 	font-size: 80%;
> 	color: #ccc;
> }
>+div#cgit div.footer a {
>+	color: #ccc;
>+	text-decoration: none;
>+}
>+div#cgit div.footer a:hover {
>+	text-decoration: underline;
>+}
> div#cgit a.branch-deco {
> 	color: #000;
> 	margin: 0px 0.5em;
>diff --git a/ui-shared.c b/ui-shared.c
>index 1ede2b0..ba173f4 100644
>--- a/ui-shared.c
>+++ b/ui-shared.c
>@@ -719,7 +719,7 @@ void cgit_print_docend()
> 	if (ctx.cfg.footer)
> 		html_include(ctx.cfg.footer);
> 	else {
>-		htmlf("<div class='footer'>generated  by cgit %s at ",
>+		htmlf("<div class='footer'>generated by <a
>href='http://git.zx2c4.com/cgit/about/'>cgit %s</a> at ",
> 			cgit_version);
> 		cgit_print_date(time(NULL), FMT_LONGDATE, ctx.cfg.local_time);
> 		html("</div>\n");

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.