List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH 1/1] git: use xz compressed archive for download
@ 2014-08-18  6:44 list
  2014-12-24  2:14 ` Jason
  0 siblings, 1 reply; 8+ messages in thread
From: list @ 2014-08-18  6:44 UTC (permalink / raw)


From: Christian Hesse <mail at eworm.de>

---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 8306028..f6e55a7 100644
--- a/Makefile
+++ b/Makefile
@@ -15,7 +15,7 @@ pdfdir = $(docdir)
 mandir = $(prefix)/share/man
 SHA1_HEADER = <openssl/sha.h>
 GIT_VER = 2.1.0
-GIT_URL = https://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.gz
+GIT_URL = https://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.xz
 INSTALL = install
 COPYTREE = cp -r
 MAN5_TXT = $(wildcard *.5.txt)
@@ -146,7 +146,7 @@ clean-doc:
 	$(RM) cgitrc.5 cgitrc.5.html cgitrc.5.pdf cgitrc.5.xml cgitrc.5.fo
 
 get-git:
-	curl -L $(GIT_URL) | tar -xzf - && rm -rf git && mv git-$(GIT_VER) git
+	curl -L $(GIT_URL) | tar -xJf - && rm -rf git && mv git-$(GIT_VER) git
 
 tags:
 	$(QUIET_TAGS)find . -name '*.[ch]' | xargs ctags
-- 
2.0.4



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/1] git: use xz compressed archive for download
  2014-08-18  6:44 [PATCH 1/1] git: use xz compressed archive for download list
@ 2014-12-24  2:14 ` Jason
  2014-12-24  8:01   ` cgit
  0 siblings, 1 reply; 8+ messages in thread
From: Jason @ 2014-12-24  2:14 UTC (permalink / raw)


Merged a variant of this.

xz is less commonly deployed, but I think modernization is a good thing in
this regard, so rolling with it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20141223/4054a424/attachment.html>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/1] git: use xz compressed archive for download
  2014-12-24  2:14 ` Jason
@ 2014-12-24  8:01   ` cgit
  2014-12-24  8:40     ` Jason
  0 siblings, 1 reply; 8+ messages in thread
From: cgit @ 2014-12-24  8:01 UTC (permalink / raw)


On Wed, 24 Dec 2014 at 03:14:46, Jason A. Donenfeld wrote:
> Merged a variant of this.
> 
> xz is less commonly deployed, but I think modernization is a good thing in
> this regard, so rolling with it.
> 

I don't think this is a good idea (I raised concerns weeks ago but
forgot to Cc the mailing list). Several tar(1) implementations don't
support the -J switch. We could add some hackery and use the xz(1)
command line utility instead but I am not sure whether the savings of
~30% justify portability hacks :)

Either way, this should be reverted or replaced by something portable.

Regards and happy holidays,
Lukas


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/1] git: use xz compressed archive for download
  2014-12-24  8:01   ` cgit
@ 2014-12-24  8:40     ` Jason
  2014-12-24 11:13       ` cgit
  0 siblings, 1 reply; 8+ messages in thread
From: Jason @ 2014-12-24  8:40 UTC (permalink / raw)


On Wed, Dec 24, 2014 at 1:01 AM, Lukas Fleischer <cgit at cryptocrack.de>
wrote:
>
> I don't think this is a good idea (I raised concerns weeks ago but
> forgot to Cc the mailing list).
>

Shucks on the CC.


I'd like to hear more opinions.
*Who out there is deploying cgit on boxes that don't have tar's -J?*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20141224/6b03c149/attachment.html>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/1] git: use xz compressed archive for download
  2014-12-24  8:40     ` Jason
@ 2014-12-24 11:13       ` cgit
  2014-12-24 11:28         ` Jason
  0 siblings, 1 reply; 8+ messages in thread
From: cgit @ 2014-12-24 11:13 UTC (permalink / raw)


On Wed, 24 Dec 2014 at 09:40:07, Jason A. Donenfeld wrote:
> On Wed, Dec 24, 2014 at 1:01 AM, Lukas Fleischer <cgit at cryptocrack.de>
> wrote:
> >
> > I don't think this is a good idea (I raised concerns weeks ago but
> > forgot to Cc the mailing list).
> >
> 
> Shucks on the CC.
> 
> 
> I'd like to hear more opinions.
> *Who out there is deploying cgit on boxes that don't have tar's -J?*

In case it wasn't obvious already: Me. OpenBSD's tar(1) does not support
that option:

    tar: unknown option -- J
    usage: tar {crtux}[014578befHhjLmNOoPpqsvwXZz]
               [blocking-factor | archive | replstr] [-C directory] [-I file]
               [file ...]
           tar {-crtux} [-014578eHhjLmNOoPpqvwXZz] [-b blocking-factor]
               [-C directory] [-f archive] [-I file] [-s replstr] [file ...]

Regards,
Lukas


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/1] git: use xz compressed archive for download
  2014-12-24 11:13       ` cgit
@ 2014-12-24 11:28         ` Jason
  0 siblings, 0 replies; 8+ messages in thread
From: Jason @ 2014-12-24 11:28 UTC (permalink / raw)


Oh, major bummer. I'll revert.

What's upstream's stance on that?
On Dec 24, 2014 12:13 PM, "Lukas Fleischer" <cgit at cryptocrack.de> wrote:

> On Wed, 24 Dec 2014 at 09:40:07, Jason A. Donenfeld wrote:
> > On Wed, Dec 24, 2014 at 1:01 AM, Lukas Fleischer <cgit at cryptocrack.de>
> > wrote:
> > >
> > > I don't think this is a good idea (I raised concerns weeks ago but
> > > forgot to Cc the mailing list).
> > >
> >
> > Shucks on the CC.
> >
> >
> > I'd like to hear more opinions.
> > *Who out there is deploying cgit on boxes that don't have tar's -J?*
>
> In case it wasn't obvious already: Me. OpenBSD's tar(1) does not support
> that option:
>
>     tar: unknown option -- J
>     usage: tar {crtux}[014578befHhjLmNOoPpqsvwXZz]
>                [blocking-factor | archive | replstr] [-C directory] [-I
> file]
>                [file ...]
>            tar {-crtux} [-014578eHhjLmNOoPpqvwXZz] [-b blocking-factor]
>                [-C directory] [-f archive] [-I file] [-s replstr] [file
> ...]
>
> Regards,
> Lukas
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20141224/ade91286/attachment.html>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/1] git: use xz compressed archive for download
  2018-11-20 22:55 list
@ 2018-11-21  1:31 ` Jason
  0 siblings, 0 replies; 8+ messages in thread
From: Jason @ 2018-11-21  1:31 UTC (permalink / raw)


Thanks, merged.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/1] git: use xz compressed archive for download
@ 2018-11-20 22:55 list
  2018-11-21  1:31 ` Jason
  0 siblings, 1 reply; 8+ messages in thread
From: list @ 2018-11-20 22:55 UTC (permalink / raw)


From: Christian Hesse <mail at eworm.de>

Upstream will stop providing gz compressed source tarballs [0], so stop
using them.

[0] https://lists.zx2c4.com/pipermail/cgit/2018-November/004254.html

Signed-off-by: Christian Hesse <mail at eworm.de>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 1c49b50..4aaf2dc 100644
--- a/Makefile
+++ b/Makefile
@@ -15,7 +15,7 @@ pdfdir = $(docdir)
 mandir = $(prefix)/share/man
 SHA1_HEADER = <openssl/sha.h>
 GIT_VER = 2.19.1
-GIT_URL = https://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.gz
+GIT_URL = https://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.xz
 INSTALL = install
 COPYTREE = cp -r
 MAN5_TXT = $(wildcard *.5.txt)
@@ -157,7 +157,7 @@ clean-doc:
 	$(RM) cgitrc.5 cgitrc.5.html cgitrc.5.pdf cgitrc.5.xml cgitrc.5.fo
 
 get-git:
-	curl -L $(GIT_URL) | tar -xzf - && rm -rf git && mv git-$(GIT_VER) git
+	curl -L $(GIT_URL) | tar -xJf - && rm -rf git && mv git-$(GIT_VER) git
 
 tags:
 	$(QUIET_TAGS)find . -name '*.[ch]' | xargs ctags


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-11-21  1:31 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-18  6:44 [PATCH 1/1] git: use xz compressed archive for download list
2014-12-24  2:14 ` Jason
2014-12-24  8:01   ` cgit
2014-12-24  8:40     ` Jason
2014-12-24 11:13       ` cgit
2014-12-24 11:28         ` Jason
2018-11-20 22:55 list
2018-11-21  1:31 ` Jason

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).