From mboxrd@z Thu Jan 1 00:00:00 1970 From: john at keeping.me.uk (John Keeping) Date: Thu, 8 Oct 2015 23:23:58 +0100 Subject: [PATCH 3/4] ui-blob: remove useless null check In-Reply-To: <1444343039-32055-1-git-send-email-john@keeping.me.uk> References: <1444343039-32055-1-git-send-email-john@keeping.me.uk> Message-ID: <1444343039-32055-4-git-send-email-john@keeping.me.uk> We have already called strlen() on "path" by the time we get here, so we know it can't be null. Coverity-id: 13954 Signed-off-by: John Keeping --- ui-blob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui-blob.c b/ui-blob.c index b333f86..d3c3a10 100644 --- a/ui-blob.c +++ b/ui-blob.c @@ -85,7 +85,7 @@ int cgit_print_file(char *path, const char *head, int file_only) if (get_sha1(head, sha1)) return -1; type = sha1_object_info(sha1, &size); - if (type == OBJ_COMMIT && path) { + if (type == OBJ_COMMIT) { commit = lookup_commit_reference(sha1); read_tree_recursive(commit->tree, "", 0, 0, &paths, walk_tree, &walk_tree_ctx); if (!walk_tree_ctx.found_path) -- 1.7.9.5