From mboxrd@z Thu Jan 1 00:00:00 1970 From: list at eworm.de (Christian Hesse) Date: Fri, 9 Oct 2015 13:15:45 +0200 Subject: [PATCH 2/8] ui-ssdiff: fix resource leak: free allocation from cgit_fileurl In-Reply-To: <1444389351-2154-1-git-send-email-list@eworm.de> References: <1444389351-2154-1-git-send-email-list@eworm.de> Message-ID: <1444389351-2154-2-git-send-email-list@eworm.de> From: Christian Hesse Coverity-id: 13929 Signed-off-by: Christian Hesse --- ui-ssdiff.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ui-ssdiff.c b/ui-ssdiff.c index 2146c71..d183d40 100644 --- a/ui-ssdiff.c +++ b/ui-ssdiff.c @@ -230,11 +230,13 @@ static void print_ssdiff_line(char *class, struct diff_filespec *old_file = cgit_get_current_old_file(); char *lineno_str = fmt("n%d", old_line_no); char *id_str = fmt("id=%s#%s", is_null_sha1(old_file->sha1)?"HEAD":sha1_to_hex(old_rev_sha1), lineno_str); + char *fileurl = cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str); html("%s", lineno_str, lineno_str + 1); html(""); htmlf("", class); + free(fileurl); } else if (old_line) htmlf("", class); else @@ -251,11 +253,13 @@ static void print_ssdiff_line(char *class, struct diff_filespec *new_file = cgit_get_current_new_file(); char *lineno_str = fmt("n%d", new_line_no); char *id_str = fmt("id=%s#%s", is_null_sha1(new_file->sha1)?"HEAD":sha1_to_hex(new_rev_sha1), lineno_str); + char *fileurl = cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str); html("%s", lineno_str, lineno_str + 1); html(""); htmlf("", class); + free(fileurl); } else if (new_line) htmlf("", class); else -- 2.6.1