From: list at eworm.de (Christian Hesse)
Subject: [PATCH 3/8] ui-shared: fix resource leak: free allocation from cgit_fileurl
Date: Fri, 9 Oct 2015 13:15:46 +0200 [thread overview]
Message-ID: <1444389351-2154-3-git-send-email-list@eworm.de> (raw)
In-Reply-To: <1444389351-2154-1-git-send-email-list@eworm.de>
From: Christian Hesse <mail at eworm.de>
Coverity-id: 13918
Signed-off-by: Christian Hesse <mail at eworm.de>
---
ui-shared.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/ui-shared.c b/ui-shared.c
index 89c4897..d9f8258 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -746,16 +746,19 @@ void cgit_print_docstart(void)
html("'/>\n");
}
if (host && ctx.repo && ctx.qry.head) {
+ char *fileurl;
struct strbuf sb = STRBUF_INIT;
strbuf_addf(&sb, "h=%s", ctx.qry.head);
html("<link rel='alternate' title='Atom feed' href='");
html(cgit_httpscheme());
html_attr(cgit_hosturl());
- html_attr(cgit_fileurl(ctx.repo->url, "atom", ctx.qry.vpath,
- sb.buf));
+ fileurl = cgit_fileurl(ctx.repo->url, "atom", ctx.qry.vpath,
+ sb.buf);
+ html_attr(fileurl);
html("' type='application/atom+xml'/>\n");
strbuf_release(&sb);
+ free(fileurl);
}
if (ctx.repo)
cgit_add_clone_urls(print_rel_vcs_link);
@@ -997,9 +1000,12 @@ void cgit_print_pageheader(void)
ctx.qry.head, ctx.qry.vpath);
html("</td><td class='form'>");
html("<form class='right' method='get' action='");
- if (ctx.cfg.virtual_root)
- html_url_path(cgit_fileurl(ctx.qry.repo, "log",
- ctx.qry.vpath, NULL));
+ if (ctx.cfg.virtual_root) {
+ char *fileurl = cgit_fileurl(ctx.qry.repo, "log",
+ ctx.qry.vpath, NULL);
+ html_url_path(fileurl);
+ free(fileurl);
+ }
html("'>\n");
cgit_add_hidden_formfields(1, 0, "log");
html("<select name='qt'>\n");
--
2.6.1
next prev parent reply other threads:[~2015-10-09 11:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 11:15 [PATCH 1/8] ui-tree: fix resource leak: free before return list
2015-10-09 11:15 ` [PATCH 2/8] ui-ssdiff: fix resource leak: free allocation from cgit_fileurl list
2015-10-09 11:59 ` Jason
2015-10-09 11:15 ` list [this message]
2015-10-09 11:15 ` [PATCH 4/8] ui-shared: return value of cgit_currenturl is not const list
2015-10-09 12:01 ` Jason
2015-10-09 11:15 ` [PATCH 5/8] ui-shared: fix resource leak: free allocation from cgit_currenturl list
2015-10-09 12:02 ` Jason
2015-10-09 11:15 ` [PATCH 6/8] cmd: fix resource leak: free allocation from cgit_currenturl and fmtalloc list
2015-10-09 12:03 ` Jason
2015-10-09 12:08 ` list
2015-10-09 12:13 ` mailings
2015-10-09 12:16 ` list
2015-10-09 12:25 ` Jason
2015-10-09 11:15 ` [PATCH 7/8] ui-shared: return value of cgit_hosturl is not const list
2015-10-09 12:04 ` Jason
2015-10-09 11:15 ` [PATCH 8/8] ui-shared: fix resource leak: free allocation from cgit_hosturl list
2015-10-09 12:04 ` Jason
2015-10-09 12:13 ` list
2015-10-09 11:58 ` [PATCH 1/8] ui-tree: fix resource leak: free before return Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444389351-2154-3-git-send-email-list@eworm.de \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).