List for cgit developers and users
 help / color / mirror / Atom feed
From: peter at colberg.org (Peter Colberg)
Subject: [PATCH v2 1/2] ui-repolist: extract repo visibility criteria to separate function
Date: Tue,  8 Dec 2015 12:53:08 -0500	[thread overview]
Message-ID: <1449597189-18086-2-git-send-email-peter@colberg.org> (raw)
In-Reply-To: <1449597189-18086-1-git-send-email-peter@colberg.org>

Signed-off-by: Peter Colberg <peter at colberg.org>
---
 ui-repolist.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/ui-repolist.c b/ui-repolist.c
index a2e9e07..f3f5353 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -106,6 +106,15 @@ static int is_in_url(struct cgit_repo *repo)
 	return 0;
 }
 
+static int is_visible(struct cgit_repo *repo)
+{
+	if (repo->hide || repo->ignore)
+		return 0;
+	if (!(is_match(repo) && is_in_url(repo)))
+		return 0;
+	return 1;
+}
+
 static void print_sort_header(const char *title, const char *sort)
 {
 	char *currenturl = cgit_currenturl();
@@ -278,9 +287,7 @@ void cgit_print_repolist(void)
 	html("<table summary='repository list' class='list nowrap'>");
 	for (i = 0; i < cgit_repolist.count; i++) {
 		ctx.repo = &cgit_repolist.repos[i];
-		if (ctx.repo->hide || ctx.repo->ignore)
-			continue;
-		if (!(is_match(ctx.repo) && is_in_url(ctx.repo)))
+		if (!is_visible(ctx.repo))
 			continue;
 		hits++;
 		if (hits <= ctx.qry.ofs)
-- 
2.6.2



  reply	other threads:[~2015-12-08 17:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 19:28 [PATCH] ui-repolist: return HTTP 404 if no repositories found peter
2015-12-07 19:28 ` peter
2015-12-07 20:28   ` john
2015-12-08 17:53     ` [PATCH v2 0/2] " peter
2015-12-08 17:53       ` peter [this message]
2016-01-13 16:15         ` [PATCH v2 1/2] ui-repolist: extract repo visibility criteria to separate function Jason
2015-12-08 17:53       ` [PATCH v2 2/2] ui-repolist: return HTTP 404 if no repositories found peter
2016-01-13 16:21         ` Jason
2016-01-13 22:25           ` peter
2016-01-13 22:25             ` [PATCH 1/2] Compile with -Wstrict-prototypes -Wmissing-prototypes peter
2016-01-13 23:29               ` john
2016-01-14 13:01                 ` Jason
2016-01-14 13:12                   ` mailings
2016-01-14 13:32                   ` john
2016-01-14 13:35                     ` Jason
2016-01-13 22:25             ` [PATCH 2/2] Fix missing prototype declarations peter
2016-01-14 13:02               ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449597189-18086-2-git-send-email-peter@colberg.org \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).