From: list at eworm.de (Christian Hesse)
Subject: [PATCH 1/1] ui-repolist: initialize char *buf to NULL
Date: Wed, 13 Jan 2016 00:45:03 +0100 [thread overview]
Message-ID: <1452642303-30792-1-git-send-email-list@eworm.de> (raw)
From: Christian Hesse <mail at eworm.de>
readfile() can fail if the agefile is not readable. Make sure free()
does not free an ininitialized string.
Signed-off-by: Christian Hesse <mail at eworm.de>
---
ui-repolist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui-repolist.c b/ui-repolist.c
index a2e9e07..8d982c4 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -15,7 +15,7 @@ static time_t read_agefile(char *path)
{
time_t result;
size_t size;
- char *buf;
+ char *buf = NULL;
struct strbuf date_buf = STRBUF_INIT;
if (readfile(path, &buf, &size)) {
--
2.7.0
next reply other threads:[~2016-01-12 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 23:45 list [this message]
2016-01-13 8:58 ` john
2016-01-13 16:08 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452642303-30792-1-git-send-email-list@eworm.de \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).