List for cgit developers and users
 help / color / mirror / Atom feed
From: peter at colberg.org (Peter Colberg)
Subject: [PATCH v2 2/2] ui-repolist: return HTTP 404 if no repositories found
Date: Wed, 13 Jan 2016 17:25:05 -0500	[thread overview]
Message-ID: <1452723907-25898-1-git-send-email-peter@colberg.org> (raw)
In-Reply-To: <CAHmME9qHcWi9V+aVNHAJJerGNFT5k62uPaaGWaJXhDKe6cFw2Q@mail.gmail.com>

On Wed, Jan 13, 2016 at 05:21:21PM +0100, Jason A. Donenfeld wrote:
> Thanks Peter. I merged this with some changes:
>
> http://git.zx2c4.com/cgit/commit/?id=9abe4a26a92b91170cb9c5dab830b40fb1e0327f

Thanks for merging, Jason.

> Note that in C you need to specify (void) in the argument list if it
> doesn't take any arguments. Otherwise it takes a variable number of
> arguments.

I knew about (void) in C and still made this mistake.

The following commits add compiler warning flags to prevent this mistake
from happening ever again and fix various declarations without (void).

Regards,
Peter

Peter Colberg (2):
  Compile with -Wstrict-prototypes -Wmissing-prototypes
  Fix missing prototype declarations

 cgit.mk       |  5 +++++
 ui-diff.h     |  2 +-
 ui-refs.h     |  2 +-
 ui-repolist.h |  4 ++--
 ui-shared.h   | 12 ++++++------
 ui-ssdiff.h   |  8 ++++----
 ui-summary.h  |  2 +-
 7 files changed, 20 insertions(+), 15 deletions(-)

-- 
2.7.0.rc3



  reply	other threads:[~2016-01-13 22:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 19:28 [PATCH] " peter
2015-12-07 19:28 ` peter
2015-12-07 20:28   ` john
2015-12-08 17:53     ` [PATCH v2 0/2] " peter
2015-12-08 17:53       ` [PATCH v2 1/2] ui-repolist: extract repo visibility criteria to separate function peter
2016-01-13 16:15         ` Jason
2015-12-08 17:53       ` [PATCH v2 2/2] ui-repolist: return HTTP 404 if no repositories found peter
2016-01-13 16:21         ` Jason
2016-01-13 22:25           ` peter [this message]
2016-01-13 22:25             ` [PATCH 1/2] Compile with -Wstrict-prototypes -Wmissing-prototypes peter
2016-01-13 23:29               ` john
2016-01-14 13:01                 ` Jason
2016-01-14 13:12                   ` mailings
2016-01-14 13:32                   ` john
2016-01-14 13:35                     ` Jason
2016-01-13 22:25             ` [PATCH 2/2] Fix missing prototype declarations peter
2016-01-14 13:02               ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452723907-25898-1-git-send-email-peter@colberg.org \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).