List for cgit developers and users
 help / color / mirror / Atom feed
From: wub at partyvan.eu (Juuso Lapinlampi)
Subject: [PATCH 2/5] Revert "ui-summary: add "rel='vcs-git'" to clone URL links"
Date: Wed, 11 May 2016 18:04:15 +0000	[thread overview]
Message-ID: <1462989858-15825-3-git-send-email-wub@partyvan.eu> (raw)
In-Reply-To: <1462989858-15825-1-git-send-email-wub@partyvan.eu>

vcs-git is not a registered keyword. This microformat does not seem to
be very popular and will throw errors in HTML validators.

Because the <link> element leaves us with no sensible rel attribute to
use, there's no reason to keep this.

For future consideration, microdata should be marked with Schema.org
markup instead.

This reverts commit d31be4ccc2f978edd2a40c2721e1efdc1eee2343.
---
 ui-summary.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/ui-summary.c b/ui-summary.c
index 8e81ac4..375bd45 100644
--- a/ui-summary.c
+++ b/ui-summary.c
@@ -31,11 +31,9 @@ static void print_url(const char *url)
 		htmlf("<tr class='nohover'><th class='left' colspan='%d'>Clone</th></tr>\n", columns);
 	}
 
-	htmlf("<tr><td colspan='%d'><a rel='vcs-git' href='", columns);
+	htmlf("<tr><td colspan='%d'><a href='", columns);
 	html_url_path(url);
-	html("' title='");
-	html_attr(ctx.repo->name);
-	html(" Git repository'>");
+	html("'>");
 	html_txt(url);
 	html("</a></td></tr>\n");
 }
-- 
2.8.1



  parent reply	other threads:[~2016-05-11 18:04 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 18:04 [PATCH 0/5] Convert to HTML, fix HTML validation issues wub
2016-05-11 18:04 ` [PATCH 1/5] ui-shared: HTML-ize DOCTYPE and <html> wub
2016-05-11 18:56   ` john
2016-05-11 19:28     ` wub
2016-05-12 15:31     ` Jason
2016-05-12 15:32   ` Jason
2016-05-12 18:58     ` wub
2016-05-12 19:04       ` Jason
2016-05-12 15:38   ` Jason
2016-05-11 18:04 ` wub [this message]
2016-05-11 18:44   ` [PATCH 2/5] Revert "ui-summary: add "rel='vcs-git'" to clone URL links" john
2016-05-12 15:34     ` Jason
2016-05-12 15:37       ` pabs3
2016-05-12 15:47         ` Jason
2016-05-12 15:49           ` pabs3
2016-05-12 15:51             ` Jason
2016-05-12 16:16               ` pabs3
2016-05-12 16:22                 ` Jason
2016-05-12 19:09       ` wub
2016-05-13  0:26         ` pabs3
2016-05-12 16:49     ` pabs3
2016-05-11 18:04 ` [PATCH 3/5] Revert "ui-shared: add rel-vcs microformat links to HTML header" wub
2016-05-11 18:45   ` john
2016-05-11 20:28     ` wub
2016-05-11 18:04 ` [PATCH 4/5] ui: Fix bad value for attribute action on form elements wub
2016-05-11 18:50   ` john
2016-05-12 15:41   ` Jason
2016-05-12 19:22     ` wub
2016-05-12 19:27       ` Jason
2016-05-12 19:29         ` Jason
2016-05-12 19:36         ` wub
2016-05-12 19:39           ` Jason
2016-05-11 18:04 ` [PATCH 5/5] ui-shared: Remove a name attribute with an empty value wub
2016-05-11 18:52   ` john
2016-05-12 15:43   ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462989858-15825-3-git-send-email-wub@partyvan.eu \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).