From: lfleischer at lfos.de (Lukas Fleischer)
Subject: [PATCH] Avoid ambiguities when prettifying snapshot names
Date: Sat, 02 Jul 2016 15:30:22 +0200 [thread overview]
Message-ID: <146746622209.13406.13026183571409299542@typhoon.lan> (raw)
In-Reply-To: <20160524161518.9839-1-lfleischer@lfos.de>
On Tue, 24 May 2016 at 18:15:18, Lukas Fleischer wrote:
> When composing snapshot file names for a tag with a prefix of the form
> v[0-9] (resp. V[0-9]), the leading "v" (resp. "V") is stripped. This
> leads to conflicts if a tag with the stripped name already exists or if
> there are tags only differing in the capitalization of the leading "v".
> Make sure we do not strip the "v" in these cases.
>
> Reported-by: Juuso Lapinlampi <wub at partyvan.eu>
> Signed-off-by: Lukas Fleischer <lfleischer at lfos.de>
> ---
> Note: The code that actually generates the snapshots works fine as it
> always tries an exact match first.
>
> ui-refs.c | 24 +++++++++---------------
> ui-shared.c | 26 +++++++++++++++++++++-----
> ui-shared.h | 2 ++
> 3 files changed, 32 insertions(+), 20 deletions(-)
Any comments on this?
next prev parent reply other threads:[~2016-07-02 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 4:57 Snapshot URLs can conflict with two similar but unique tags wub
2016-05-23 5:11 ` wub
2016-05-24 16:15 ` [PATCH] Avoid ambiguities when prettifying snapshot names lfleischer
2016-07-02 13:30 ` lfleischer [this message]
2016-07-02 20:04 ` Jason
2016-07-05 14:13 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146746622209.13406.13026183571409299542@typhoon.lan \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).