List for cgit developers and users
 help / color / mirror / Atom feed
From: lfleischer at lfos.de (Lukas Fleischer)
Subject: Crash when using path limit in ui-patch.c
Date: Thu, 24 Nov 2016 20:14:32 +0100	[thread overview]
Message-ID: <148001487252.31859.12978476848749661933@typhoon> (raw)
In-Reply-To: <20161124184854.GA24063@john.keeping.me.uk>

On Thu, 24 Nov 2016 at 19:49:06, John Keeping wrote:
> [...]
> diff --git a/ui-patch.c b/ui-patch.c
> index ec7f3523..d29f74c7 100644
> --- a/ui-patch.c
> +++ b/ui-patch.c
> @@ -85,8 +85,7 @@ void cgit_print_patch(const char *new_rev, const char *old_rev,
>                         DIFF_FORMAT_PATCH | DIFF_FORMAT_SUMMARY;
>         if (prefix)
>                 rev.diffopt.stat_sep = fmt("(limited to '%s')\n\n", prefix);
> -       setup_revisions(ARRAY_SIZE(rev_argv), rev_argv, &rev,
> -                       NULL);
> +       setup_revisions(rev_argc, rev_argv, &rev, NULL);

I noticed that, too, when trying to find the culprit but the actual
issue is that the array is not NULL-terminated. Will submit a patch
soon.

>         prepare_revision_walk(&rev);
>  
>         while ((commit = get_revision(&rev)) != NULL) {
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit


      reply	other threads:[~2016-11-24 19:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24  9:57 bluewind
2016-11-24 18:49 ` john
2016-11-24 19:14   ` lfleischer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=148001487252.31859.12978476848749661933@typhoon \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).