From: andy at warmcat.com (Andy Green)
Subject: [PATCH v6 7/7] line-range-highlight: copy text
Date: Fri, 29 Jun 2018 09:40:49 +0800 [thread overview]
Message-ID: <153023644986.27756.14726184679474709272.stgit@mail.warmcat.com> (raw)
In-Reply-To: <153023597876.27756.7476186508120329174.stgit@mail.warmcat.com>
Implement picking a line range or single line
from the textContent version of the rendered
source to the clipboard.
It works in blame and tree the same.
Signed-off-by: Andy Green <andy at warmcat.com>
---
cgit.js | 51 +++++++++++++++++++++++++++++++++++++++++----------
1 file changed, 41 insertions(+), 10 deletions(-)
diff --git a/cgit.js b/cgit.js
index 7fae9aa..bc2ba65 100644
--- a/cgit.js
+++ b/cgit.js
@@ -31,6 +31,25 @@ function find_parent_of_type(e, type)
return e;
}
+function parse_hashurl_start(h)
+{
+ return parseInt(h.substring(2));
+}
+
+function parse_hashurl_end(h, start)
+{
+ var t = h.indexOf("-"), e = start;
+
+ if (t >= 1)
+ e = parseInt(h.substring(t + 1));
+
+ if (e < start)
+ e = start;
+
+ return e;
+}
+
+
/*
* This creates an absolute div as a child of the content table.
* It's horizontally and vertically aligned and sized according
@@ -56,17 +75,11 @@ function line_range_highlight(do_burger)
e.remove();
}
- l1 = parseInt(h.substring(2));
+ l1 = parse_hashurl_start(h);
if (!l1)
return;
- t = h.indexOf("-");
- l2 = l1;
- if (t >= 1)
- l2 = parseInt(h.substring(t + 1));
-
- if (l2 < l1)
- l2 = l1;
+ l2 = parse_hashurl_end(h, l1);
var lh, etable, etr, de, n, hl, v;
@@ -142,18 +155,36 @@ function copy_clipboard(value)
inp.remove();
}
+/* we want to copy plain text for a line range */
+
+function copy_text(elem, l1, l2)
+{
+ var tc = elem.textContent.split('\n'), s = "";
+
+ l1 --;
+
+ while (l1 < l2)
+ s += tc[l1++] + '\n';
+
+ copy_clipboard(s);
+}
+
+
/*
* An element in the popup menu was clicked, perform the appropriate action
*/
function mi_click(e) {
- var u, n;
+ var u, n, l1, l2, el;
e.stopPropagation();
e.preventDefault();
switch (e.target.id) {
case "mi-c-line":
- /* implemented in next patch */
+ l1 = parse_hashurl_start(window.location.hash);
+ l2 = parse_hashurl_end(window.location.hash, l1);
+ el = document.getElementsByClassName("highlight")[0].firstChild;
+ copy_text(el, l1, l2);
break;
case "mi-c-link":
copy_clipboard(window.location.href);
prev parent reply other threads:[~2018-06-29 1:40 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 9:39 Highlighting lines or line ranges in tree view andy
2018-06-21 5:42 ` [PATCH 1/3] ui-shared: introduce line range highlight javascript andy
2018-06-21 7:03 ` list
2018-06-21 7:30 ` andy
2018-06-21 5:42 ` [PATCH 2/3] ui-tree: use the line range highlight script andy
2018-06-21 5:43 ` [PATCH 3/3] ui-blame: " andy
2018-06-21 9:34 ` [PATCH v2 0/5] line range highlight andy
2018-06-21 9:34 ` [PATCH v2 1/5] config: add js andy
2018-06-23 10:20 ` john
2018-06-23 10:34 ` andy
2018-06-21 9:34 ` [PATCH v2 2/5] cgit.js: introduce andy
2018-06-23 10:18 ` john
2018-06-21 9:34 ` [PATCH v2 3/5] ui-shared: introduce line range highlight javascript andy
2018-06-23 10:17 ` john
2018-06-24 2:37 ` andy
2018-06-21 9:35 ` [PATCH v2 4/5] ui-tree: use the line range highlight script andy
2018-06-21 9:35 ` [PATCH v2 5/5] ui-blame: " andy
2018-06-22 23:01 ` [PATCH v2 1/2] cgit.js: make line range highlight responsive to url changes andy
2018-06-22 23:02 ` [PATCH v2 2/2] cgit.js: line range highlight: improve vertical scroll logic andy
2018-06-23 7:45 ` [PATCH v2] cgit.js: line range highlight: always hook hashchange in case hash added andy
2018-06-24 2:44 ` [PATCH v3 0/6] line range highlight andy
2018-06-24 2:44 ` [PATCH v3 1/6] config: add js andy
2018-06-24 11:01 ` john
2018-06-24 2:44 ` [PATCH v3 2/6] ui-shared: line range highlight: introduce javascript andy
2018-06-24 11:28 ` john
2018-06-25 2:04 ` andy
2018-06-24 2:44 ` [PATCH v3 3/6] cgit.js: line range highlight: make responsive to url changes andy
2018-06-24 2:44 ` [PATCH v3 4/6] cgit.js: line range highlight: improve vertical scroll logic andy
2018-06-24 2:44 ` [PATCH v3 5/6] line-range-highlight: onclick handler and range selection andy
2018-06-24 11:35 ` john
2018-06-25 2:07 ` andy
2018-06-24 2:44 ` [PATCH v3 6/6] line-range-highlight: copy URL to clipboard on click andy
2018-06-24 11:42 ` john
2018-06-24 12:00 ` andy
2018-06-24 13:39 ` john
2018-06-24 15:06 ` andy
2018-06-24 16:03 ` john
2018-06-25 0:46 ` andy
2018-06-25 5:49 ` [PATCH v4 0/6] line range highlight andy
2018-06-25 5:49 ` [PATCH v4 1/6] config: add js andy
2018-06-26 8:03 ` list
2018-06-25 5:49 ` [PATCH v4 2/6] cgit.js: line range highlight: introduce javascript andy
2018-06-25 5:49 ` [PATCH v4 3/6] cgit.js: line range highlight: make responsive to url changes andy
2018-06-25 5:50 ` [PATCH v4 4/6] cgit.js: line range highlight: improve vertical scroll logic andy
2018-06-25 5:50 ` [PATCH v4 5/6] line-range-highlight: onclick handler and range selection andy
2018-06-25 5:50 ` [PATCH v4 6/6] line-range-highlight: copy URL to clipboard UI andy
2018-06-26 11:25 ` [PATCH v5 0/6] line range highlight andy
2018-06-26 11:25 ` [PATCH v5 1/6] config: add js andy
2018-06-26 11:25 ` [PATCH v5 2/6] cgit.js: line range highlight: introduce javascript andy
2018-06-27 18:02 ` Jason
2018-06-27 21:45 ` andy
2018-06-28 23:58 ` [PATCH] cgit.css: add copyright lines andy
2018-06-26 11:25 ` [PATCH v5 3/6] cgit.js: line range highlight: make responsive to url changes andy
2018-06-26 11:25 ` [PATCH v5 4/6] cgit.js: line range highlight: improve vertical scroll logic andy
2018-06-26 11:25 ` [PATCH v5 5/6] line-range-highlight: onclick handler and range selection andy
2018-06-26 11:51 ` [PATCH v5-ninjaedit] " andy
2018-06-26 11:25 ` [PATCH v5 6/6] line-range-highlight: copy URL to clipboard UI andy
2018-06-27 18:07 ` Jason
2018-06-27 23:24 ` andy
2018-06-27 23:30 ` Jason
2018-06-27 23:38 ` andy
2018-06-29 1:39 ` [PATCH v6 0/7] line range highlight andy
2018-06-29 1:40 ` [PATCH v6 1/7] config: add js andy
2018-06-29 6:14 ` list
2018-06-29 6:16 ` [PATCH v6-ninjaedit] " andy
2018-06-29 6:31 ` [PATCH v6-ninjaedit2] " andy
2018-06-29 6:33 ` [PATCH v6-ninjaedit] " list
2018-06-29 1:40 ` [PATCH v6 2/7] cgit.js: line range highlight: introduce javascript andy
2018-06-29 1:40 ` [PATCH v6 3/7] cgit.js: line range highlight: make responsive to url changes andy
2018-06-29 1:40 ` [PATCH v6 4/7] cgit.js: line range highlight: improve vertical scroll logic andy
2018-06-29 1:40 ` [PATCH v6 5/7] line-range-highlight: onclick handler and range selection andy
2018-06-29 1:40 ` [PATCH v6 6/7] line-range-highlight: burger menu and popup menu andy
2018-06-29 1:40 ` andy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153023644986.27756.14726184679474709272.stgit@mail.warmcat.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).