From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) by inbox.vuxu.org (Postfix) with ESMTP id 0DD7B211F4 for ; Sun, 4 Aug 2024 05:02:28 +0200 (CEST) Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id f56dc162; Sun, 4 Aug 2024 03:02:12 +0000 (UTC) Received: from mail.kasad.com (mail.kasad.com [140.82.7.10]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 7853f8ba (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 4 Aug 2024 03:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kasad.com; i=@kasad.com; q=dns/txt; s=mail; t=1722740529; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to : from; bh=QLGO8twqlre75+9PmYeBMyIOqFbxkwk+soHJIyxRC4I=; b=rU6Yo1DzGB3gMVk1HPAeQ3uYRNKcCHsQGiOfRVGJGV+quaS/1MSUOpT6a45+8Q1GOCH6h Thla7knCYHZOBItUMMZMW0pOHosi5XzWzQjIV2yEqH/rmhBg5/0msmssWw0mPJbIWjdl0eN WT7L03IH+7Sit0vaLzajEVR8B51DjNsLcziZNs3QgvzGXGck8Bwx0UxgsFi1WRYpgVU51vP jcnQj+bnXGoWOc8K2AaMRNEz5LveWBG1OdwFQ31iY1hLqxP6QEIZycAw/Y5X2BVg0iMkB8A 2DWoIDPvB5Gsbmh9DJ+GpOASyX5rRyzYupxr9XuW78EIPOFIqa1j6344MEQw== Received: from smtpclient.apple (unknown [IPv6:2601:644:8301:e800:19d:b583:c65f:e3ba]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kasad.com (Postfix) with ESMTPSA id DFEC422B8B; Sat, 3 Aug 2024 23:02:08 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: Typo introduced #2f50b47 From: Kian Kasad In-Reply-To: Date: Sat, 3 Aug 2024 20:01:57 -0700 Cc: Alexander Pickering Content-Transfer-Encoding: quoted-printable Message-Id: <1BAC615F-471C-42B2-AABF-32A8D0A4F758@kasad.com> References: To: cgit@lists.zx2c4.com X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" > On Aug 3, 2024, at 14:52, Alexander Pickering wrote: >=20 > ../scan-tree.c:57:65: error: parameter name omitted > 57 | ic int gitconfig_config(const char *key, const char *value, > const struct config_context *, void *cb) >=20 > I think this line >=20 > static int gitconfig_config(const char *key, const char *value, = const struct config_context *, void *cb) >=20 > should be >=20 > static int gitconfig_config(const char *key, const char *value, = void *cb) I agree that that=E2=80=99s a mistake, but I disagree with your = suggested change. The gitconfig_config() function is passed as the first argument to the git_config_from_file() function which is defined in git/config.c. That = function expects the first argument to be of type config_fn_t, which does have = the context argument. This is why it was added to gitconfig_config(). = Therefore, the proper solution is to just give that argument a name, as removing it = completely could cause further errors: static int gitconfig_config(const char *key, const char *value, = const struct config_context *UNUSED, void *cb) Git seems to use the name =E2=80=9CUNUSED=E2=80=9D which is why I have = followed suit here. --=20 Kian Kasad kian@kasad.com (925) 871-9823