From: plenz at cis.fu-berlin.de (Julius Plenz)
Subject: [PATCH 1/5] guess default branch from HEAD
Date: Wed, 16 Mar 2011 11:53:06 +0100 [thread overview]
Message-ID: <20110316105305.GA29888@plenz.com> (raw)
In-Reply-To: <AANLkTikfEQG2ibazmo_KxTzd2ZUUnGa0MXqFdJpnfE6W@mail.gmail.com>
Hi, Lars!
* Lars Hjemli <hjemli at gmail.com> [2011-03-10 18:24]:
> On Thu, Mar 10, 2011 at 17:03, Julius Plenz <plenz at cis.fu-berlin.de> wrote:
> > This is a saner alternative than hardcoding the default branch to be
> > "master". The add_repo() function will now check for a symbolic ref in
> > repo_path/HEAD. If there is a suitable one, overwrite repo->defbranch
> > with it.
>
> I agree with the motivation, but...
> > + fd = open(fmt("%s/HEAD", repo->path), O_RDONLY);
> ...since git supports fs links, you'll need to lstat() and then
> either readlink() or read_in_full(). And if you readlink(), you'll
> obviously need to parse the result differently.
I just tried this out:
$ cd /repositories/...
$ mv HEAD head
$ ln -s head HEAD
The patch handles that just fine (it wouldn't if I were to add the
O_NOFOLLOW flag); however, git complains:
$ git rev-list -1 HEAD
fatal: Not a git repository (or any parent up to mount parent )
With hardlinks, neither git complains, nor the patch fails.
Julius
next prev parent reply other threads:[~2011-03-16 10:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 16:03 plenz
2011-03-10 16:03 ` [PATCH 2/5] get_commit_date() obtains newest commit date plenz
2011-03-10 16:03 ` [PATCH 3/5] make enable-log-linecount independent of -filecount plenz
2011-03-10 17:25 ` hjemli
2011-03-26 14:43 ` hjemli
2011-03-10 16:03 ` [PATCH 4/5] fix two encoding bugs plenz
2011-03-10 17:29 ` hjemli
2011-03-10 16:03 ` [PATCH 5/5] Add advice about scan-path in cgitrc.5.txt plenz
2011-03-10 17:33 ` hjemli
2011-03-10 17:22 ` [PATCH 1/5] guess default branch from HEAD hjemli
2011-03-16 10:53 ` plenz [this message]
2011-03-26 10:08 ` hjemli
2011-03-30 16:00 ` [PATCH v2] " plenz
2011-04-07 9:44 ` hjemli
2011-04-07 10:49 ` plenz
2011-04-07 10:59 ` [PATCH] " plenz
2011-06-10 6:42 ` jugg
2011-06-13 10:16 ` larsh
2011-06-13 10:16 ` hjemli
2011-06-16 14:59 ` plenz
2011-06-20 19:25 ` hjemli
2011-07-09 8:09 ` jugg
2011-07-13 15:10 ` plenz
2011-07-19 7:08 ` larsh
2011-07-19 9:40 ` jugg
2011-07-19 6:30 ` larsh
2011-07-19 9:35 ` jugg
2011-07-19 9:56 ` larsh
2011-07-19 10:13 ` jugg
2011-07-21 10:34 ` larsh
2011-04-07 11:05 ` [PATCH v2] " hjemli
2011-06-09 4:40 ` jugg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316105305.GA29888@plenz.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).