* [PATCH] Remove unused variable from cgit_diff_tree().
@ 2011-03-30 17:48 cgit
2011-04-07 11:36 ` hjemli
0 siblings, 1 reply; 3+ messages in thread
From: cgit @ 2011-03-30 17:48 UTC (permalink / raw)
Seen with "-Wunused-but-set-variable".
Signed-off-by: Lukas Fleischer <cgit at cryptocrack.de>
---
shared.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/shared.c b/shared.c
index 7ec2e19..9961bc9 100644
--- a/shared.c
+++ b/shared.c
@@ -311,7 +311,6 @@ void cgit_diff_tree(const unsigned char *old_sha1,
filepair_fn fn, const char *prefix, int ignorews)
{
struct diff_options opt;
- int ret;
int prefixlen;
diff_setup(&opt);
@@ -332,9 +331,9 @@ void cgit_diff_tree(const unsigned char *old_sha1,
diff_setup_done(&opt);
if (old_sha1 && !is_null_sha1(old_sha1))
- ret = diff_tree_sha1(old_sha1, new_sha1, "", &opt);
+ diff_tree_sha1(old_sha1, new_sha1, "", &opt);
else
- ret = diff_root_tree_sha1(new_sha1, "", &opt);
+ diff_root_tree_sha1(new_sha1, "", &opt);
diffcore_std(&opt);
diff_flush(&opt);
}
--
1.7.4.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Remove unused variable from cgit_diff_tree().
2011-03-30 17:48 [PATCH] Remove unused variable from cgit_diff_tree() cgit
@ 2011-04-07 11:36 ` hjemli
2011-04-10 17:32 ` cgit
0 siblings, 1 reply; 3+ messages in thread
From: hjemli @ 2011-04-07 11:36 UTC (permalink / raw)
On Wed, Mar 30, 2011 at 19:48, Lukas Fleischer <cgit at cryptocrack.de> wrote:
> @@ -311,7 +311,6 @@ void cgit_diff_tree(const unsigned char *old_sha1,
> ? ? ? ? ? ? ? ? ? ?filepair_fn fn, const char *prefix, int ignorews)
> ?{
> ? ? ? ?struct diff_options opt;
> - ? ? ? int ret;
> ? ? ? ?int prefixlen;
>
> ? ? ? ?diff_setup(&opt);
> @@ -332,9 +331,9 @@ void cgit_diff_tree(const unsigned char *old_sha1,
> ? ? ? ?diff_setup_done(&opt);
>
> ? ? ? ?if (old_sha1 && !is_null_sha1(old_sha1))
> - ? ? ? ? ? ? ? ret = diff_tree_sha1(old_sha1, new_sha1, "", &opt);
> + ? ? ? ? ? ? ? diff_tree_sha1(old_sha1, new_sha1, "", &opt);
> ? ? ? ?else
> - ? ? ? ? ? ? ? ret = diff_root_tree_sha1(new_sha1, "", &opt);
> + ? ? ? ? ? ? ? diff_root_tree_sha1(new_sha1, "", &opt);
> ? ? ? ?diffcore_std(&opt);
> ? ? ? ?diff_flush(&opt);
> ?}
Thanks, will apply.
--
larsh
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Remove unused variable from cgit_diff_tree().
2011-04-07 11:36 ` hjemli
@ 2011-04-10 17:32 ` cgit
0 siblings, 0 replies; 3+ messages in thread
From: cgit @ 2011-04-10 17:32 UTC (permalink / raw)
On Thu, Apr 07, 2011 at 01:36:59PM +0200, Lars Hjemli wrote:
> On Wed, Mar 30, 2011 at 19:48, Lukas Fleischer <cgit at cryptocrack.de> wrote:
> > @@ -311,7 +311,6 @@ void cgit_diff_tree(const unsigned char *old_sha1,
> > ? ? ? ? ? ? ? ? ? ?filepair_fn fn, const char *prefix, int ignorews)
> > ?{
> > ? ? ? ?struct diff_options opt;
> > - ? ? ? int ret;
> > ? ? ? ?int prefixlen;
> >
> > ? ? ? ?diff_setup(&opt);
> > @@ -332,9 +331,9 @@ void cgit_diff_tree(const unsigned char *old_sha1,
> > ? ? ? ?diff_setup_done(&opt);
> >
> > ? ? ? ?if (old_sha1 && !is_null_sha1(old_sha1))
> > - ? ? ? ? ? ? ? ret = diff_tree_sha1(old_sha1, new_sha1, "", &opt);
> > + ? ? ? ? ? ? ? diff_tree_sha1(old_sha1, new_sha1, "", &opt);
> > ? ? ? ?else
> > - ? ? ? ? ? ? ? ret = diff_root_tree_sha1(new_sha1, "", &opt);
> > + ? ? ? ? ? ? ? diff_root_tree_sha1(new_sha1, "", &opt);
> > ? ? ? ?diffcore_std(&opt);
> > ? ? ? ?diff_flush(&opt);
> > ?}
>
> Thanks, will apply.
Thanks. This is in my working tree [1] as well [2], btw.
[1] http://git.cryptocrack.de/cgit.git/log/?h=wip
[2] http://git.cryptocrack.de/cgit.git/commit/?h=wip&id=214ea073
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-10 17:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-30 17:48 [PATCH] Remove unused variable from cgit_diff_tree() cgit
2011-04-07 11:36 ` hjemli
2011-04-10 17:32 ` cgit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).