From: larsh at hjemli.net (larsh at hjemli.net)
Subject: [PATCH] cgit.c: use resolve_ref() to guess_defbranch()
Date: Mon, 20 Jun 2011 23:37:01 +0000 [thread overview]
Message-ID: <20110620233701.GA11444@hjemli.net> (raw)
The resolve_ref() function handles reading of git- and filesystem
symbolic links (including proper whitespace trimming) and packed refs.
There's no point in reimplementing this function in cgit.
Signed-off-by: Lars Hjemli <hjemli at gmail.com>
--
After deploying the wip-branch on hjemli.net, I noticed that the
default branch in the git.git repository wasn't correctly set. This was
due the HEAD symbolic ref having two trailing newlines, so I started
looking into how the git code handled this case and ended up with this
patch.
diff --git a/cgit.c b/cgit.c
index e3fbbf4..624cb2c 100644
--- a/cgit.c
+++ b/cgit.c
@@ -418,33 +418,13 @@ char *find_default_branch(struct cgit_repo *repo)
static char *guess_defbranch(const char *repo_path)
{
- int fd, len;
- char buffer[256];
- char *ref_start;
- char *head;
-
- head = fmt("%s/HEAD", repo_path);
- fd = open(head, O_RDONLY);
- if (fd == -1)
- return xstrdup("master");
-
- memset(buffer, 0, sizeof(buffer));
- len = read_in_full(fd, buffer, sizeof(buffer) - 1);
- close(fd);
-
- if(!memcmp(buffer, "ref: refs/heads/", 16))
- return xstrndup(buffer + 16, len - 17);
-
- if(strlen(buffer) == 41) {
- /* probably contains a SHA1 sum */
- memset(buffer, 0, sizeof(buffer));
- if(readlink(head, buffer, sizeof(buffer)-1)) {
- ref_start = memmem(buffer, sizeof(buffer)-1, "refs/heads/", 11);
- if(ref_start)
- return xstrdup(ref_start+11);
- }
- }
- return xstrdup("master");
+ const char *ref;
+ unsigned char sha1[20];
+
+ ref = resolve_ref("HEAD", sha1, 0, NULL);
+ if (!ref || prefixcmp(ref, "refs/heads/"))
+ return "master";
+ return xstrdup(ref + 11);
}
static int prepare_repo_cmd(struct cgit_context *ctx)
next reply other threads:[~2011-06-20 23:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 23:37 larsh [this message]
2011-06-20 23:39 ` Fwd: " hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620233701.GA11444@hjemli.net \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).