From: larsh at hjemli.net (larsh at hjemli.net)
Subject: paging and sorting in the repository overview
Date: Thu, 21 Jul 2011 10:30:50 +0000 [thread overview]
Message-ID: <20110721103050.GC8377@hjemli.net> (raw)
In-Reply-To: <20110720135701.106e3800@gmx.de>
On Wed, Jul 20, 2011 at 01:57:01PM +0200, Thomas Moschny wrote:
> we are displaying a whole bunch (>50) of repositories via cgit, and
> there's a small issue with the overview page: it seems paging is done
> before sorting. Or, more precisely, repositories are first sorted
> alphabetically, then paging is done, and finally the requested sort
> order (for example according to their idle time via ?s=idle) is applied
> to the page. I'd instead expect sorting to be done before paging.
Yeah, this looks like a bug - cgit_index_link(), used by print_pager()
in ui-repolist.c, doesn't honor the sort option. I'll push a fix
tonight (currently at $DAYJOB).
--
larsh
prev parent reply other threads:[~2011-07-21 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 11:57 thomas.moschny
2011-07-21 10:30 ` larsh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110721103050.GC8377@hjemli.net \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).