* paging and sorting in the repository overview
@ 2011-07-20 11:57 thomas.moschny
2011-07-21 10:30 ` larsh
0 siblings, 1 reply; 2+ messages in thread
From: thomas.moschny @ 2011-07-20 11:57 UTC (permalink / raw)
Hi,
we are displaying a whole bunch (>50) of repositories via cgit, and
there's a small issue with the overview page: it seems paging is done
before sorting. Or, more precisely, repositories are first sorted
alphabetically, then paging is done, and finally the requested sort
order (for example according to their idle time via ?s=idle) is applied
to the page. I'd instead expect sorting to be done before paging.
- Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
* paging and sorting in the repository overview
2011-07-20 11:57 paging and sorting in the repository overview thomas.moschny
@ 2011-07-21 10:30 ` larsh
0 siblings, 0 replies; 2+ messages in thread
From: larsh @ 2011-07-21 10:30 UTC (permalink / raw)
On Wed, Jul 20, 2011 at 01:57:01PM +0200, Thomas Moschny wrote:
> we are displaying a whole bunch (>50) of repositories via cgit, and
> there's a small issue with the overview page: it seems paging is done
> before sorting. Or, more precisely, repositories are first sorted
> alphabetically, then paging is done, and finally the requested sort
> order (for example according to their idle time via ?s=idle) is applied
> to the page. I'd instead expect sorting to be done before paging.
Yeah, this looks like a bug - cgit_index_link(), used by print_pager()
in ui-repolist.c, doesn't honor the sort option. I'll push a fix
tonight (currently at $DAYJOB).
--
larsh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-21 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-20 11:57 paging and sorting in the repository overview thomas.moschny
2011-07-21 10:30 ` larsh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).