From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH 1/2] tests: handle paths with whitespace
Date: Thu, 19 Jan 2012 21:54:31 +0100 [thread overview]
Message-ID: <20120119205431.GA13613@blizzard> (raw)
In-Reply-To: <1327001055-29027-1-git-send-email-mailings@hupie.com>
On Thu, Jan 19, 2012 at 08:24:14PM +0100, Ferry Huberts wrote:
> From: Ferry Huberts <ferry.huberts at pelagic.nl>
>
> Signed-off-by: Ferry Huberts <ferry.huberts at pelagic.nl>
> ---
> tests/setup.sh | 4 ++--
> tests/t0108-patch.sh | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/setup.sh b/tests/setup.sh
> index b21908d..3b52de9 100755
> --- a/tests/setup.sh
> +++ b/tests/setup.sh
> @@ -20,7 +20,7 @@ unset CDPATH
> mkrepo() {
> name=$1
> count=$2
> - dir=$PWD
> + dir="$PWD"
You can skip the quotes in assignments. Variable assignments are
expanded for tilde expansion, parameter expansion, command substitution,
arithmetic expansion and quote removal - field splitting isn't
performed. If we add redundant quotes here, we should add them to all
assignments (I'm for omitting them, though).
Apart from that, I'm fine with this patch :)
> test -d "$name" && return
> printf "Creating testrepo %s\n" $name
> mkdir -p "$name"
> @@ -41,7 +41,7 @@ mkrepo() {
> git commit -m "add a+b"
> git branch "1+2"
> fi
> - cd $dir
> + cd "$dir"
> }
>
> setup_repos()
> diff --git a/tests/t0108-patch.sh b/tests/t0108-patch.sh
> index e608104..6ee70b3 100755
> --- a/tests/t0108-patch.sh
> +++ b/tests/t0108-patch.sh
> @@ -25,7 +25,7 @@ run_test 'find `cgit` signature' '
> '
>
> run_test 'find initial commit' '
> - root=$(git --git-dir=$PWD/trash/repos/foo/.git rev-list HEAD | tail -1)
> + root=$(git --git-dir="$PWD/trash/repos/foo/.git" rev-list HEAD | tail -1)
> '
>
> run_test 'generate patch for initial commit' '
> --
> 1.7.7.5
>
>
> _______________________________________________
> cgit mailing list
> cgit at hjemli.net
> http://hjemli.net/mailman/listinfo/cgit
next prev parent reply other threads:[~2012-01-19 20:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 19:24 mailings
2012-01-19 19:24 ` [PATCH 2/2] tests: properly quote more variables mailings
2012-01-19 20:57 ` cgit
2012-01-19 21:08 ` mailings
2012-01-21 20:39 ` cgit
2012-01-19 20:54 ` cgit [this message]
2012-01-29 15:29 ` [PATCH v2 1/2] tests: handle paths with whitespace mailings
2012-01-29 15:29 ` [PATCH v2 2/2] tests: properly quote arguments to printf mailings
2012-03-06 22:26 ` [PATCH v2 1/2] tests: handle paths with whitespace mailings
2012-03-06 22:26 ` [PATCH v2 2/2] tests: properly quote arguments to printf mailings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119205431.GA13613@blizzard \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).