List for cgit developers and users
 help / color / mirror / Atom feed
From: cgit at cryptocrack.de (Lukas Fleischer)
Subject: [PATCH v2 2/3] highlight: declare variables
Date: Tue, 21 Feb 2012 14:23:05 +0100	[thread overview]
Message-ID: <20120221132305.GB12346@blizzard> (raw)
In-Reply-To: <1329826411-6301-2-git-send-email-mailings@hupie.com>

On Tue, Feb 21, 2012 at 01:13:30PM +0100, Ferry Huberts wrote:
> From: Ferry Huberts <ferry.huberts at pelagic.nl>
> 
> Signed-off-by: Ferry Huberts <ferry.huberts at pelagic.nl>
> ---
>  filters/syntax-highlighting.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/filters/syntax-highlighting.sh b/filters/syntax-highlighting.sh
> index c930e07..0f97fea 100755
> --- a/filters/syntax-highlighting.sh
> +++ b/filters/syntax-highlighting.sh
> @@ -36,8 +36,8 @@
>  #
>  
>  # store filename and extension in local vars
> -BASENAME="$1"
> -EXTENSION="${BASENAME##*.}"
> +declare BASENAME="$1"
> +declare EXTENSION="${BASENAME##*.}"

"declare" isn't POSIX'ish and we shouldn't rely on bashishms unless Lars
agrees and we change the shebang to "#!/bin/bash".

>  
>  # map Makefile and Makefile.* to .mk
>  [ "${BASENAME%%.*}" == "Makefile" ] && EXTENSION=mk
> -- 
> 1.7.7.6




  reply	other threads:[~2012-02-21 13:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-21 12:13 [PATCH v2 1/3] highlight: add workaround for empty lines getting filtered out mailings
2012-02-21 12:13 ` [PATCH v2 2/3] highlight: declare variables mailings
2012-02-21 13:23   ` cgit [this message]
2012-02-21 12:13 ` [PATCH v2 3/3] highlight: fix syntax highlighting for program versions > 2 mailings
2012-02-21 13:27   ` cgit
2012-02-21 13:47     ` mailings
2012-02-21 14:21       ` cgit
2012-02-21 13:16 ` [PATCH v2 1/3] highlight: add workaround for empty lines getting filtered out cgit
2012-02-21 13:45   ` mailings
2012-02-21 14:23     ` cgit
2012-02-21 15:21       ` mailings
2012-02-21 18:41       ` mailings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120221132305.GB12346@blizzard \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).